From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29355 invoked by alias); 18 Jul 2013 17:36:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29330 invoked by uid 89); 18 Jul 2013 17:36:05 -0000 X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO mail-pb0-f48.google.com) (209.85.160.48) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 18 Jul 2013 17:36:01 +0000 Received: by mail-pb0-f48.google.com with SMTP id ma3so3424803pbc.35 for ; Thu, 18 Jul 2013 10:35:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=NnJscGXt1VIkMDalqpYRcyEJ1RJZ3gHGvXRVrz4RDB4=; b=CiOx/NgceHpSngvv2jKtz9l5rcLD86LX3dlluyi3cgI/NuCsFL3k1CYfVfNa4nICBO AW+H8xw1Lp4v8YBkgMmMLWUmzmnn0VjlOqh10+/R5RtdtUzir+DIXZy8ajE+45aWXYu0 Bg2ZiHqmkNWmwJN+BnOAHUxaqBxxbjXqxfHwgjJkNoc4DsFQ0DlFuPg7c+D8sxH03Oue ExmJnuHi1YVwvbB1uEY1jLqOCRPMYTHdh8wawmbiu3EFb3B4aZlxSpco7XMsDirjnof/ 0lTa4mq2eMzT14Oswc4CyTYgvX7joO+dnPVaoG1eRpAECFlEKCzaOyIjQArwWv+4JIWn 9JVg== MIME-Version: 1.0 X-Received: by 10.66.13.202 with SMTP id j10mr14261731pac.181.1374168953903; Thu, 18 Jul 2013 10:35:53 -0700 (PDT) Received: by 10.69.14.98 with HTTP; Thu, 18 Jul 2013 10:35:53 -0700 (PDT) In-Reply-To: <386B40EC5E8DBF459FD11A754D868AD922E31112@BADAG02.ba.imgtec.org> References: <386B40EC5E8DBF459FD11A754D868AD922E31112@BADAG02.ba.imgtec.org> Date: Thu, 18 Jul 2013 18:14:00 -0000 Message-ID: Subject: Re: [PATCH] Add a new option "-ftree-bitfield-merge" (patch / doc inside) From: Cary Coutant To: Zoran Jovanovic Cc: "gcc-patches@gcc.gnu.org" , Petar Jovanovic Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnMUhYxaom8yRoVf7/hbzM4HNArqeJy7IHb5JBn38xDURJLQih0iwaNwvLZeaiP1WkP9f1eBWzAZtqxjih/jTGVr0yGerltPDrZaKrPQKkYVHptxRvD2Af4XTjUdgxQbQFgMLapa9WISfbpjRDZSGKGR3caRQ6+8cRPaEHvXWxjK0YWlqQaonud1sFkdrBRw1XdSnSorQa73/+2tJPRTmbzkrv5sg== X-SW-Source: 2013-07/txt/msg00735.txt.bz2 > * dwarf2out.c (field_type): static removed from declaration. > (simple_type_size_in_bits): static removed from declaration. > (field_byte_offset): static removed from declaration. > (field_type): static inline removed from declaration. If you're going to use these declarations from tree-ssa-bitfield-merge.c, it would be better to move the declarations into dwarf2out.h, and include that file from tree-ssa-bitfield-merge.c. Even better would be to move these routines (which today are in dwarf2out.c simply because that was the only file that needed them) to a more appropriate location. I'd suggest tree.h/tree.c, but tree.c is already way too big -- does someone have a better suggestion? -cary