* Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)
@ 2011-09-23 5:59 Cary Coutant
2011-09-23 8:42 ` Jakub Jelinek
0 siblings, 1 reply; 7+ messages in thread
From: Cary Coutant @ 2011-09-23 5:59 UTC (permalink / raw)
To: gcc-patches; +Cc: Jakub Jelinek
> Ping?
>
> http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html
>
> -cary
>
>
> include/ChangeLog:
>
> PR 40831
> * demangle.h (enum demangle_component_type): Add
> DEMANGLE_COMPONENT_CLONE.
>
> libiberty/ChangeLog:
>
> PR 40831
> * cp-demangle.c (d_make_comp): Add new component type.
> (cplus_demangle_mangled_name): Check for clone suffixes.
> (d_parmlist): Don't error out if we see '.'.
> (d_clone_suffix): New function.
> (d_print_comp): Print info for clone suffixes.
> * testsuite/demangle-expected: Add new testcases.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)
2011-09-23 5:59 Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831) Cary Coutant
@ 2011-09-23 8:42 ` Jakub Jelinek
2011-09-23 15:54 ` Ian Lance Taylor
0 siblings, 1 reply; 7+ messages in thread
From: Jakub Jelinek @ 2011-09-23 8:42 UTC (permalink / raw)
To: Cary Coutant, Ian Lance Taylor; +Cc: gcc-patches
On Thu, Sep 22, 2011 at 05:40:15PM -0700, Cary Coutant wrote:
> > Ping?
> >
> > http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html
It looks good to me, but I'd prefer if Ian with his demangler author
and libiberty maintainer hats looked at it too.
> > include/ChangeLog:
> >
> > Â Â Â Â PR 40831
> > Â Â Â Â * demangle.h (enum demangle_component_type): Add
> > Â Â Â Â DEMANGLE_COMPONENT_CLONE.
> >
> > libiberty/ChangeLog:
> >
> > Â Â Â Â PR 40831
> > Â Â Â Â * cp-demangle.c (d_make_comp): Add new component type.
> > Â Â Â Â (cplus_demangle_mangled_name): Check for clone suffixes.
> > Â Â Â Â (d_parmlist): Don't error out if we see '.'.
> > Â Â Â Â (d_clone_suffix): New function.
> > Â Â Â Â (d_print_comp): Print info for clone suffixes.
> > Â Â Â Â * testsuite/demangle-expected: Add new testcases.
Maybe the testcase should test also
_Z2f1IiEvT_S0_S0_._omp_fn.2
_Z3fooi._omp_cpyfn.6
as examples of OpenMP suffixing - the former is an example of name
used for outlined #pragma omp {parallel,task} region from a function
and the latter is for copy constructors needed for #pragma omp task.
Jakub
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)
2011-09-23 8:42 ` Jakub Jelinek
@ 2011-09-23 15:54 ` Ian Lance Taylor
2011-09-23 22:25 ` Cary Coutant
0 siblings, 1 reply; 7+ messages in thread
From: Ian Lance Taylor @ 2011-09-23 15:54 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Cary Coutant, gcc-patches
Jakub Jelinek <jakub@redhat.com> writes:
> On Thu, Sep 22, 2011 at 05:40:15PM -0700, Cary Coutant wrote:
>> > Ping?
>> >
>> > http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html
>
> It looks good to me, but I'd prefer if Ian with his demangler author
> and libiberty maintainer hats looked at it too.
This patch is OK, with or without the testsuite additions Jakub
mentions.
Thanks.
Ian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)
2011-09-23 15:54 ` Ian Lance Taylor
@ 2011-09-23 22:25 ` Cary Coutant
2011-09-23 23:46 ` Cary Coutant
0 siblings, 1 reply; 7+ messages in thread
From: Cary Coutant @ 2011-09-23 22:25 UTC (permalink / raw)
To: Ian Lance Taylor; +Cc: Jakub Jelinek, gcc-patches
> This patch is OK, with or without the testsuite additions Jakub
> mentions.
Thanks, I added the new tests, and tweaked the clone suffix parsing to
allow the leading "_".
Committed as r179132.
-cary
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)
2011-09-23 22:25 ` Cary Coutant
@ 2011-09-23 23:46 ` Cary Coutant
2011-09-24 9:08 ` Ian Lance Taylor
0 siblings, 1 reply; 7+ messages in thread
From: Cary Coutant @ 2011-09-23 23:46 UTC (permalink / raw)
To: Ian Lance Taylor; +Cc: Jakub Jelinek, gcc-patches
>> This patch is OK, with or without the testsuite additions Jakub
>> mentions.
>
> Thanks, I added the new tests, and tweaked the clone suffix parsing to
> allow the leading "_".
>
> Committed as r179132.
Should I backport this patch to gcc-4_6-branch?
-cary
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)
2011-09-23 23:46 ` Cary Coutant
@ 2011-09-24 9:08 ` Ian Lance Taylor
2011-09-26 20:03 ` Cary Coutant
0 siblings, 1 reply; 7+ messages in thread
From: Ian Lance Taylor @ 2011-09-24 9:08 UTC (permalink / raw)
To: Cary Coutant; +Cc: Jakub Jelinek, gcc-patches
Cary Coutant <ccoutant@google.com> writes:
>>> This patch is OK, with or without the testsuite additions Jakub
>>> mentions.
>>
>> Thanks, I added the new tests, and tweaked the clone suffix parsing to
>> allow the leading "_".
>>
>> Committed as r179132.
>
> Should I backport this patch to gcc-4_6-branch?
Since you offer, that would be nice.
Ian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)
2011-09-24 9:08 ` Ian Lance Taylor
@ 2011-09-26 20:03 ` Cary Coutant
0 siblings, 0 replies; 7+ messages in thread
From: Cary Coutant @ 2011-09-26 20:03 UTC (permalink / raw)
To: Ian Lance Taylor; +Cc: Jakub Jelinek, gcc-patches
> >>> This patch is OK, with or without the testsuite additions Jakub
> >>> mentions.
> >>
> >> Thanks, I added the new tests, and tweaked the clone suffix parsing to
> >> allow the leading "_".
> >>
> >> Committed as r179132.
> >
> > Should I backport this patch to gcc-4_6-branch?
>
> Since you offer, that would be nice.
OK, committed to gcc-4_6-branch as r179209.
-cary
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-09-26 18:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-23 5:59 Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831) Cary Coutant
2011-09-23 8:42 ` Jakub Jelinek
2011-09-23 15:54 ` Ian Lance Taylor
2011-09-23 22:25 ` Cary Coutant
2011-09-23 23:46 ` Cary Coutant
2011-09-24 9:08 ` Ian Lance Taylor
2011-09-26 20:03 ` Cary Coutant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).