From: Paolo Bonzini <bonzini@gnu.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: PING: PATCH [4/n]: Prepare x32: Permute the conversion and addition if one operand is a constant
Date: Wed, 13 Jul 2011 16:58:00 -0000 [thread overview]
Message-ID: <CAHFMJ7uyk_+66FpFWz4q5ra8-UfF+PTV9MaZiT4dhX8jgHAGBQ@mail.gmail.com> (raw)
In-Reply-To: <CAHFMJ7vSBKw=7uJXUfSsHY56VRSVY2hLQ+bn3k6os_XT5OEvXQ@mail.gmail.com>
>>> Why? Certainly Y = 8 has 31-bit (or less) precision. So it has the same
>>> representation in SImode and DImode, and the test above on XEXP (x, 1)
>>> succeeds.
>>
>> And then we permute conversion and addition, which leads to the issue you
>> raised above. In another word, the current code permutes conversion
>> and addition.
>
> No, only if we have ptr_extend.
Oops, hit send too early, I understand now what you mean. But even
more so, let's make sure x32 is done right so that perhaps we can
remove the bogus test on XEXP (x, 1) for other Pmode != ptr_mode
targets, non-ptr_extend. Then we can worry perhaps of
POINTERS_EXTEND_UNSIGNED < 0.
Paolo
next prev parent reply other threads:[~2011-07-13 16:55 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 14:30 H.J. Lu
2011-07-09 21:22 ` H.J. Lu
2011-07-09 21:23 ` Paolo Bonzini
2011-07-09 21:41 ` H.J. Lu
2011-07-10 17:04 ` Paolo Bonzini
2011-07-10 21:16 ` H.J. Lu
2011-07-11 0:48 ` H.J. Lu
2011-07-11 1:14 ` H.J. Lu
2011-07-11 6:49 ` H.J. Lu
2011-07-11 11:09 ` Paolo Bonzini
2011-07-11 15:58 ` H.J. Lu
2011-07-11 16:57 ` H.J. Lu
2011-07-11 17:26 ` H.J. Lu
2011-07-13 16:24 ` Paolo Bonzini
2011-07-13 16:52 ` H.J. Lu
2011-07-13 16:55 ` Paolo Bonzini
2011-07-13 16:58 ` Paolo Bonzini [this message]
2011-07-13 18:42 ` H.J. Lu
2011-07-25 10:34 ` Paolo Bonzini
2011-07-27 18:18 ` H.J. Lu
2011-07-27 22:41 ` Paolo Bonzini
2011-07-28 3:11 ` H.J. Lu
2011-07-28 7:59 ` Paolo Bonzini
2014-05-29 4:52 ` Andrew Pinski
2014-05-29 16:13 ` H.J. Lu
2014-05-29 16:23 ` pinskia
2014-05-29 17:09 ` H.J. Lu
2014-05-29 17:20 ` pinskia
2014-05-30 7:18 ` Paolo Bonzini
2011-07-28 10:24 Uros Bizjak
2011-07-28 10:27 ` Paolo Bonzini
2011-07-29 13:29 ` H.J. Lu
2011-07-28 18:23 ` Uros Bizjak
2011-07-29 9:32 ` Paolo Bonzini
2011-07-29 9:37 ` Paolo Bonzini
2011-07-30 0:47 ` H.J. Lu
2011-07-30 16:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHFMJ7uyk_+66FpFWz4q5ra8-UfF+PTV9MaZiT4dhX8jgHAGBQ@mail.gmail.com \
--to=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).