From: "Bin.Cheng" <amker.cheng@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: Paolo Carlini <paolo.carlini@oracle.com>,
Andreas Schwab <schwab@suse.de>,
"libstdc++" <libstdc++@gcc.gnu.org>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR libstdc++/53984 handle exceptions in basic_istream::sentry
Date: Thu, 27 Jul 2017 08:50:00 -0000 [thread overview]
Message-ID: <CAHFci2-6L36tVq-PeotGCoWwUZ1MMAMUeAvJ-ObimcVF-GFsAw@mail.gmail.com> (raw)
In-Reply-To: <20170726220611.GV15340@redhat.com>
On Wed, Jul 26, 2017 at 11:06 PM, Jonathan Wakely <jwakely@redhat.com> wrote:
> On 26/07/17 20:14 +0200, Paolo Carlini wrote:
>>
>> Hi again,
>>
>> On 26/07/2017 16:27, Paolo Carlini wrote:
>>>
>>> Hi,
>>>
>>> On 26/07/2017 16:21, Andreas Schwab wrote:
>>>>
>>>> ERROR: 27_io/basic_fstream/53984.cc: unknown dg option:
>>>> dg-require-file-io 18 {} for " dg-require-file-io 18 "" "
>>>
>>> Should be already fixed, a trivial typo.
>>
>> ... but now the new test simply fails for me. If I don't spot something
>> else trivial over the next few hours I guess better waiting for Jon to look
>> into that.
>
>
> Sorry about that, I must have only checked for FAILs and missed the
> ERRORs.
>
> It should have been an ifstream not fstream, otherwise the filebuf
> can't even open the file. Fixed like so, committed to trunk.
Hi, I have seen below failure on aarch64/arm linux/elf:
spawn [open ...]^M
/tmp/.../src/gcc/libstdc++-v3/testsuite/27_io/basic_fstream/53984.cc:29:
void test01(): Assertion 'in.bad()' failed.
FAIL: 27_io/basic_fstream/53984.cc execution test
extra_tool_flags are:
-include bits/stdc++.h
Thanks,
bin
>
>
next prev parent reply other threads:[~2017-07-27 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 20:43 Jonathan Wakely
2017-07-26 14:21 ` Andreas Schwab
2017-07-26 14:27 ` Paolo Carlini
2017-07-26 18:14 ` Paolo Carlini
2017-07-26 20:43 ` Ville Voutilainen
2017-07-26 22:06 ` Jonathan Wakely
2017-07-27 8:50 ` Bin.Cheng [this message]
2017-08-11 3:04 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHFci2-6L36tVq-PeotGCoWwUZ1MMAMUeAvJ-ObimcVF-GFsAw@mail.gmail.com \
--to=amker.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).