From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15446 invoked by alias); 11 Aug 2016 08:43:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 14867 invoked by uid 89); 11 Aug 2016 08:43:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_40,FREEMAIL_FROM,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=2498, *comparison, sk:maybeu, vcond_mask X-HELO: mail-ua0-f182.google.com Received: from mail-ua0-f182.google.com (HELO mail-ua0-f182.google.com) (209.85.217.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 11 Aug 2016 08:43:42 +0000 Received: by mail-ua0-f182.google.com with SMTP id n59so108456433uan.2 for ; Thu, 11 Aug 2016 01:43:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=b5C2UHNDKzROO/GIRNB0mJAJS9+zy2K4gITKsNh5ZKg=; b=T1dJlfvW5vCm6Yp63zKiLOpLFr0iajbRMDofaGPmD/y2sQKPaeDxk1bNc74Fx2pHpk BbxSWFH3K/GnibEuEKDEp7pdyjHIahK8JYziVQyGxN/1u5rlPxz595YY5gMWzq/Ehu6F nSVriAljna7Jbuug501GIEl8hIjaXydIexG9xeWJrYVCf3hbT+hOUiuikbSJjXBCM3nB OiDjLESgd9N2iF9BcCa4W0YVArge66jDRJ+iNl9Iknpu+3DpCkyp8Flc+1VcaO6pzBEG HG/QgASmnhZ5NiV7SAImW5w/kpGV2rUCOVw/iJvM5uUKOFLYtr8YEntL6MwimyTMsghr 1HsQ== X-Gm-Message-State: AEkoouuIcfXL/g1crAhSCAbuO7vgd2jKkzhuSH5hjBVn8GqMsuACDkaKGLCm3B4XScUIatNKrAAu+NEedEb4dA== X-Received: by 10.159.34.38 with SMTP id 35mr4073584uad.2.1470905020650; Thu, 11 Aug 2016 01:43:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.134.151 with HTTP; Thu, 11 Aug 2016 01:43:40 -0700 (PDT) In-Reply-To: References: <20160808104028.GA27339@arm.com> From: "Bin.Cheng" Date: Thu, 11 Aug 2016 08:43:00 -0000 Message-ID: Subject: Re: [PATCH AArch64/V3]Add new patterns for vcond_mask and vec_cmp To: Andreas Schwab Cc: James Greenhalgh , Bin Cheng , "gcc-patches@gcc.gnu.org" , nd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00887.txt.bz2 On Thu, Aug 11, 2016 at 9:36 AM, Bin.Cheng wrote: > On Thu, Aug 11, 2016 at 8:08 AM, Andreas Schwab wrote: >> ../../gcc/config/aarch64/aarch64-simd.md: In function 'rtx_def* gen_vec_= cmpv2sfv2si(rtx, rtx, rtx, rtx)': >> ../../gcc/config/aarch64/aarch64-simd.md:2498:17: error: 'comparison' ma= y be used uninitialized in this function [-Werror=3Dmaybe-uninitialized] >> emit_insn (comparison (operands[0], operands[2], operands[3])); >> ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> ../../gcc/config/aarch64/aarch64-simd.md:2416:9: note: 'comparison' was = declared here >> rtx (*comparison) (rtx, rtx, rtx); >> ^~~~~~~~~~ >> ../../gcc/config/aarch64/aarch64-simd.md: In function 'rtx_def* gen_vec_= cmpv4sfv4si(rtx, rtx, rtx, rtx)': >> ../../gcc/config/aarch64/aarch64-simd.md:2498:17: error: 'comparison' ma= y be used uninitialized in this function [-Werror=3Dmaybe-uninitialized] >> emit_insn (comparison (operands[0], operands[2], operands[3])); >> ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> ../../gcc/config/aarch64/aarch64-simd.md:2416:9: note: 'comparison' was = declared here >> rtx (*comparison) (rtx, rtx, rtx); >> ^~~~~~~~~~ >> ../../gcc/config/aarch64/aarch64-simd.md: In function 'rtx_def* gen_vec_= cmpv2dfv2di(rtx, rtx, rtx, rtx)': >> ../../gcc/config/aarch64/aarch64-simd.md:2498:17: error: 'comparison' ma= y be used uninitialized in this function [-Werror=3Dmaybe-uninitialized] >> emit_insn (comparison (operands[0], operands[2], operands[3])); >> ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> ../../gcc/config/aarch64/aarch64-simd.md:2416:9: note: 'comparison' was = declared here >> rtx (*comparison) (rtx, rtx, rtx); >> ^~~~~~~~~~ > > Hi Andreas, > Thanks very much for reporting this. > > I also got below error messages: > ../../gcc/gcc/config/aarch64/aarch64-simd.md: In function =E2=80=98rtx_de= f* > gen_vcondv8qiv8qi(rtx, rtx, rtx, rtx, rtx, rtx)=E2=80=99: > ../../gcc/gcc/config/aarch64/aarch64-simd.md:2574:17: error: unused > variable =E2=80=98code=E2=80=99 [-Werror=3Dunused-variable] > enum rtx_code code =3D GET_CODE (operands[3]); > ^~~~ > ../../gcc/gcc/config/aarch64/aarch64-simd.md: In function =E2=80=98rtx_de= f* > gen_vcondv16qiv16qi(rtx, rtx, rtx, rtx, rtx, rtx)=E2=80=99: > ../../gcc/gcc/config/aarch64/aarch64-simd.md:2574:17: error: unused > variable =E2=80=98code=E2=80=99 [-Werror=3Dunused-variable] > enum rtx_code code =3D GET_CODE (operands[3]); > ^~~~ > ../../gcc/gcc/config/aarch64/aarch64-simd.md: In function =E2=80=98rtx_de= f* > gen_vcondv4hiv4hi(rtx, rtx, rtx, rtx, rtx, rtx)=E2=80=99: > ../../gcc/gcc/config/aarch64/aarch64-simd.md:2574:17: error: unused > variable =E2=80=98code=E2=80=99 [-Werror=3Dunused-variable] > enum rtx_code code =3D GET_CODE (operands[3]); > ^~~~ > My bad forgetting to remove this when separating the patch set, the > following patch > @https://gcc.gnu.org/ml/gcc-patches/2016-08/msg00842.html will fix > this. > > For the reported error message, I think it's a bug in > maybe-unintialized warning, because all uses of "comparison" are > initialized in the previous switch statement. I will initialize it > explicitly, also file a PR for recording. PR73550 filed. Thanks, bin