From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35595 invoked by alias); 31 May 2017 12:43:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 35586 invoked by uid 89); 31 May 2017 12:43:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-vk0-f54.google.com Received: from mail-vk0-f54.google.com (HELO mail-vk0-f54.google.com) (209.85.213.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 May 2017 12:43:10 +0000 Received: by mail-vk0-f54.google.com with SMTP id p85so7532211vkd.3 for ; Wed, 31 May 2017 05:43:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ml497dR2k2prjx5uv/5WcOCYpJVH2iYCzcJsMA62XgQ=; b=aVmzyB4W1PTq/mU/3G/tXf/ngLAIMJXcadyEMLNXEdbiFTcCxKGK5ae8MKa9JtwX79 9QC7h5/oID1l8pUW00eiJCY2yC8ZoyKu7Uj63SjGdN1XTwgWTkvUPKz/pI4CbK8EtVSp y5ALQb44iEuhkC2jiRbiSApv0dONcwoTLzfy9CPuCnfPdLHiDsCdI/EnluEYE8InEMRu /Te83fO8Q45hMIFqxJyrsBmx3k5YrSGY6Bbk2fiUNQRy1m/PT9JEFfPYlNPB1Q+n8AJe h3I9nf5nisRBLzVzt30ILAHZ3ueJJjlKt88MyNLKQ8olCG8nj6AVv0+I6+D2Z7hED9B2 9cqA== X-Gm-Message-State: AODbwcC5lqqeVofPTTBcp11QF9EWsrDwUNVZgRylmuwgTscgA2OKsP1B ANdEDt+VW4Iuc72JUPyWrFkjilQEDA== X-Received: by 10.31.61.16 with SMTP id k16mr11701396vka.43.1496234592326; Wed, 31 May 2017 05:43:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.49.9 with HTTP; Wed, 31 May 2017 05:43:11 -0700 (PDT) In-Reply-To: References: From: "Bin.Cheng" Date: Wed, 31 May 2017 12:45:00 -0000 Message-ID: Subject: Re: [PATCH TEST]Rectify test case gcc.dg/tree-ssa/ivopt_mult_4.c To: Richard Biener Cc: "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary="001a114d93146152210550d1430b" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg02352.txt.bz2 --001a114d93146152210550d1430b Content-Type: text/plain; charset="UTF-8" Content-length: 1216 On Fri, May 26, 2017 at 12:49 PM, Richard Biener wrote: > On Thu, May 25, 2017 at 8:00 PM, Bin Cheng wrote: >> Hi, >> I believe this tests has been wrongly modified previously. It is to test that the exit check on >> pointer shouldn't be replaced by integer IV. Somehow GCC starts replacing the check on >> integer IV with pointer IV. It's valid, though inefficient. And somehow we starting checking >> this iv replacement. This patch rectifies it by specifically checking the check on pointer >> shouldn't be replaced. > > So maybe it should then test that the pointer test prevails? Or > rather that it doesn't replace > any exit test? If 'p' changes for '_2' for unrelated reasons the > pattern will be not testing what > it is supposed to test... Thanks for reviewing, I updated patch testing if condition on p_limit2 still exists before expanding. Is it OK? Thanks, bin > > Richard. > >> Bootstrap and test in series on x86_64. Is it OK? >> Thanks, >> bin >> gcc/testsuite/ChangeLog >> 2017-05-11 Bin Cheng >> >> * gcc.dg/tree-ssa/ivopt_mult_4.c: Explicitly check comparison >> on pointer should not be replaced. --001a114d93146152210550d1430b Content-Type: text/plain; charset="US-ASCII"; name="rectify-ivopt_mult_4.txt" Content-Disposition: attachment; filename="rectify-ivopt_mult_4.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j3czeyur0 Content-length: 1090 ZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3RyZWUtc3NhL2l2 b3B0X211bHRfNC5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvdHJlZS1zc2Ev aXZvcHRfbXVsdF80LmMKaW5kZXggZWZmYjA1Mi4uZTY5ZTQxNiAxMDA2NDQK LS0tIGEvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvdHJlZS1zc2EvaXZvcHRfbXVs dF80LmMKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvdHJlZS1zc2EvaXZv cHRfbXVsdF80LmMKQEAgLTEsNiArMSw2IEBACiAKIC8qIHsgZGctZG8gY29t cGlsZSB7IHRhcmdldCB7eyBpPzg2LSotKiB4ODZfNjQtKi0qIH0gJiYgbHA2 NCB9IH0gfSAqLwotLyogeyBkZy1vcHRpb25zICItTzIgLW02NCAtZmR1bXAt dHJlZS1pdm9wdHMtZGV0YWlscyIgfSAqLworLyogeyBkZy1vcHRpb25zICIt TzIgLW02NCAtZmR1bXAtdHJlZS1vcHRpbWl6ZWQiIH0gKi8KIAogLyogaXYg aSdzIHN0ZXAgMTYgc28gaXRzIHBlcmlvZCBpcyBzbWFsbGVyIHRoYW4gdGhl IG1heCBpdGVyYXRpb25zCiAgKiBpLmUuIHJlcGxhY2luZyBpZiAocDIgPiBw X2xpbWl0Mikgd2l0aCB0ZXN0aW5nIG9mIGkgbWF5IHJlc3VsdCBpbgpAQCAt MjEsNCArMjEsNCBAQCBsb25nIGZvbyhsb25nKiBwLCBsb25nKiBwMiwgaW50 IE4xLCBpbnQgTjIpCiAgIHJldHVybiBzOwogfQogCi0vKiB7IGRnLWZpbmFs IHsgc2Nhbi10cmVlLWR1bXAgIlJlcGxhY2luZyBleGl0IHRlc3QiICJpdm9w dHMifSB9ICovCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAgImlm IFxcKC4qcF9saW1pdDIuKlxcKSIgIm9wdGltaXplZCJ9IH0gKi8K --001a114d93146152210550d1430b--