From: "Bin.Cheng" <amker.cheng@gmail.com>
To: Tamar Christina <Tamar.Christina@arm.com>
Cc: James Greenhalgh <James.Greenhalgh@arm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][GCC][AArch64] optimize float immediate moves (2 /4) - HF/DF/SF mode.
Date: Tue, 01 Aug 2017 12:04:00 -0000 [thread overview]
Message-ID: <CAHFci282+z7RRSZt1VUG2MCfO0DqyeZkq_onCDw4CA6GLs_FNg@mail.gmail.com> (raw)
In-Reply-To: <HE1PR0802MB23166ED79F8AA86E19157102FFB30@HE1PR0802MB2316.eurprd08.prod.outlook.com>
On Tue, Aug 1, 2017 at 12:51 PM, Tamar Christina
<Tamar.Christina@arm.com> wrote:
>>
>> Given review comment already pointed out big-endian issue and patch was
>> updated to address it, I would expect reg-test on a big-endian target before
>> applying patch, right?
>
> The patch spent 6 months in external review.
> Given that, I simply forgot to rerun big endian before the commit as I did the rest.
>
> The failing tests were all added after the submission of this patch. I'll have a look.
I may bisect to wrong commit? The patch is committed three days ago,
how could all failing tests be added after it?
Thanks,
bin
prev parent reply other threads:[~2017-08-01 12:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 11:38 Tamar Christina
2017-06-12 7:31 ` Tamar Christina
2017-06-14 10:06 ` Richard Sandiford
2017-06-15 13:25 ` Tamar Christina
2017-06-15 14:28 ` Tamar Christina
2017-06-16 7:53 ` Richard Sandiford
2017-06-16 8:42 ` Tamar Christina
2017-06-14 8:43 ` James Greenhalgh
2017-06-21 10:48 ` Tamar Christina
2017-06-26 10:50 ` Tamar Christina
2017-07-03 6:12 ` Tamar Christina
2017-07-10 7:35 ` Tamar Christina
2017-07-27 16:09 ` James Greenhalgh
2017-08-01 11:47 ` Bin.Cheng
2017-08-01 11:51 ` Tamar Christina
2017-08-01 12:04 ` Bin.Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHFci282+z7RRSZt1VUG2MCfO0DqyeZkq_onCDw4CA6GLs_FNg@mail.gmail.com \
--to=amker.cheng@gmail.com \
--cc=James.Greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Tamar.Christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).