From: "Bin.Cheng" <amker.cheng@gmail.com>
To: Andreas Schwab <schwab@suse.de>
Cc: James Greenhalgh <james.greenhalgh@arm.com>,
Bin Cheng <Bin.Cheng@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
nd <nd@arm.com>
Subject: Re: [PATCH AArch64/V3]Add new patterns for vcond_mask and vec_cmp
Date: Thu, 11 Aug 2016 08:37:00 -0000 [thread overview]
Message-ID: <CAHFci28GiXGGvA4i2bTu9+rJ8FKPSJ-7Sq-HHozG9fts9TM9vA@mail.gmail.com> (raw)
In-Reply-To: <mvmoa4zsryq.fsf@hawking.suse.de>
On Thu, Aug 11, 2016 at 8:08 AM, Andreas Schwab <schwab@suse.de> wrote:
> ../../gcc/config/aarch64/aarch64-simd.md: In function 'rtx_def* gen_vec_cmpv2sfv2si(rtx, rtx, rtx, rtx)':
> ../../gcc/config/aarch64/aarch64-simd.md:2498:17: error: 'comparison' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> emit_insn (comparison (operands[0], operands[2], operands[3]));
> ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/config/aarch64/aarch64-simd.md:2416:9: note: 'comparison' was declared here
> rtx (*comparison) (rtx, rtx, rtx);
> ^~~~~~~~~~
> ../../gcc/config/aarch64/aarch64-simd.md: In function 'rtx_def* gen_vec_cmpv4sfv4si(rtx, rtx, rtx, rtx)':
> ../../gcc/config/aarch64/aarch64-simd.md:2498:17: error: 'comparison' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> emit_insn (comparison (operands[0], operands[2], operands[3]));
> ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/config/aarch64/aarch64-simd.md:2416:9: note: 'comparison' was declared here
> rtx (*comparison) (rtx, rtx, rtx);
> ^~~~~~~~~~
> ../../gcc/config/aarch64/aarch64-simd.md: In function 'rtx_def* gen_vec_cmpv2dfv2di(rtx, rtx, rtx, rtx)':
> ../../gcc/config/aarch64/aarch64-simd.md:2498:17: error: 'comparison' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> emit_insn (comparison (operands[0], operands[2], operands[3]));
> ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/config/aarch64/aarch64-simd.md:2416:9: note: 'comparison' was declared here
> rtx (*comparison) (rtx, rtx, rtx);
> ^~~~~~~~~~
Hi Andreas,
Thanks very much for reporting this.
I also got below error messages:
../../gcc/gcc/config/aarch64/aarch64-simd.md: In function ‘rtx_def*
gen_vcondv8qiv8qi(rtx, rtx, rtx, rtx, rtx, rtx)’:
../../gcc/gcc/config/aarch64/aarch64-simd.md:2574:17: error: unused
variable ‘code’ [-Werror=unused-variable]
enum rtx_code code = GET_CODE (operands[3]);
^~~~
../../gcc/gcc/config/aarch64/aarch64-simd.md: In function ‘rtx_def*
gen_vcondv16qiv16qi(rtx, rtx, rtx, rtx, rtx, rtx)’:
../../gcc/gcc/config/aarch64/aarch64-simd.md:2574:17: error: unused
variable ‘code’ [-Werror=unused-variable]
enum rtx_code code = GET_CODE (operands[3]);
^~~~
../../gcc/gcc/config/aarch64/aarch64-simd.md: In function ‘rtx_def*
gen_vcondv4hiv4hi(rtx, rtx, rtx, rtx, rtx, rtx)’:
../../gcc/gcc/config/aarch64/aarch64-simd.md:2574:17: error: unused
variable ‘code’ [-Werror=unused-variable]
enum rtx_code code = GET_CODE (operands[3]);
^~~~
My bad forgetting to remove this when separating the patch set, the
following patch
@https://gcc.gnu.org/ml/gcc-patches/2016-08/msg00842.html will fix
this.
For the reported error message, I think it's a bug in
maybe-unintialized warning, because all uses of "comparison" are
initialized in the previous switch statement. I will initialize it
explicitly, also file a PR for recording.
Thanks,
bin
>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
next prev parent reply other threads:[~2016-08-11 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 13:19 Bin Cheng
2016-08-08 10:40 ` James Greenhalgh
2016-08-08 11:10 ` Bin.Cheng
2016-08-09 14:05 ` James Greenhalgh
2016-08-11 7:08 ` Andreas Schwab
2016-08-11 8:37 ` Bin.Cheng [this message]
2016-08-11 8:43 ` Bin.Cheng
2017-06-28 5:10 ` Andrew Pinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHFci28GiXGGvA4i2bTu9+rJ8FKPSJ-7Sq-HHozG9fts9TM9vA@mail.gmail.com \
--to=amker.cheng@gmail.com \
--cc=Bin.Cheng@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=james.greenhalgh@arm.com \
--cc=nd@arm.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).