From: "Bin.Cheng" <amker.cheng@gmail.com>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>
Cc: Bin Cheng <bin.cheng@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH testcase]Skip test pr61772.c for lto tests
Date: Fri, 08 Aug 2014 08:24:00 -0000 [thread overview]
Message-ID: <CAHFci28V=49Xq=WGXpfmQ8G=eHMkxgs=+1cxoLeQ7JWE6-00aQ@mail.gmail.com> (raw)
In-Reply-To: <53E484B2.10309@arm.com>
On Fri, Aug 8, 2014 at 4:05 PM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
>
> On 07/08/14 10:43, Bin Cheng wrote:
>>
>> Hi,
>> Case pr61772.c scans specific string in assembly file, and it is run for
>> many different option combinations. When it's tested against different
>> lto
>> option combinations on targets like ARM, the generated pr61772.s may only
>> contain lto object content, rather than assembly codes. The scanning
>> check
>> is failed in these cases.
>> I think disabling lto won't weaken the test since what it tests has
>> nothing
>> to do with lto. This patch fixes these failures by disabling lto.
>>
>> Is it OK?
>
>
> Hi Bin,
>
> Do you think it would be better to just add -ffat-lto-objects instead? That
> way the output would contain the assembly as well. Example patch attached.
>
> We might want check that LTO doesn't optimise the assembly away?
Not actually. It's a compilation time test and IMHO if-conversion
optimization here has nothing to do with lto. Another reason here is
we can't just add a single lto option without support full lto
testing. Consider scenario testing on a target without lto? Please
correct if I was wrong.
Thanks,
bin
>
> Kyrill
>
>
>> Thanks,
>> bin
>>
>> gcc/testsuite/ChangeLog
>> 2014-08-07 Bin Cheng <bin.cheng@arm.com>
>>
>> * gcc.dg/torture/pr61772.c: Skip lto running.
next prev parent reply other threads:[~2014-08-08 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 9:43 Bin Cheng
2014-08-07 12:04 ` Richard Biener
2014-08-08 8:05 ` Kyrill Tkachov
2014-08-08 8:24 ` Bin.Cheng [this message]
2014-08-08 10:02 ` Kyrill Tkachov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHFci28V=49Xq=WGXpfmQ8G=eHMkxgs=+1cxoLeQ7JWE6-00aQ@mail.gmail.com' \
--to=amker.cheng@gmail.com \
--cc=bin.cheng@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).