From: "Bin.Cheng" <amker.cheng@gmail.com>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: bin.cheng@linux.alibaba.com, gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH PR84648]Adjust loop exit conditions for loop-until-wrap cases.
Date: Mon, 12 Nov 2018 02:07:00 -0000 [thread overview]
Message-ID: <CAHFci28Vzgy=pp2QF=8S4wm68SQ0mmp1G6mDo52uv6z53dK3GQ@mail.gmail.com> (raw)
In-Reply-To: <20181111122032.38b0fa1c@nbbrfq.loc>
On Sun, Nov 11, 2018 at 7:20 PM Bernhard Reutner-Fischer
<rep.dot.nop@gmail.com> wrote:
>
> On Sun, 11 Nov 2018 16:02:33 +0800
> "bin.cheng" <bin.cheng@linux.alibaba.com> wrote:
>
> Quick observation unrelated to the real patch.
>
> I think the coding style mandates to use the type itself and not the
> underlying structure.
>
> I know there are alot of places from before our switch to C++ that
> still use enum tree_code or enum machine_mode, but new code should
> adhere to the style please.
>
> So: s/enum tree_code/tree_code/g
Thanks very much for reminding, I forgot the switch when writing the
patch, will update along with changes for other reviews.
Thanks,
bin
>
> thanks,
next prev parent reply other threads:[~2018-11-12 2:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 8:02 bin.cheng
2018-11-11 11:20 ` Bernhard Reutner-Fischer
2018-11-12 2:07 ` Bin.Cheng [this message]
2018-11-13 15:03 ` Richard Biener
2018-11-14 10:09 ` bin.cheng
2018-11-14 10:18 ` Richard Biener
2018-11-19 13:17 ` Christophe Lyon
2018-11-20 10:49 ` Bin.Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHFci28Vzgy=pp2QF=8S4wm68SQ0mmp1G6mDo52uv6z53dK3GQ@mail.gmail.com' \
--to=amker.cheng@gmail.com \
--cc=bin.cheng@linux.alibaba.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).