From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 09FF939551F8 for ; Mon, 26 Jul 2021 01:48:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09FF939551F8 Received: by mail-ej1-x636.google.com with SMTP id oz16so5542913ejc.7 for ; Sun, 25 Jul 2021 18:48:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7DWcxt0KQUoL1RcsVYYVDoYDvsiGcx3K4httt7bR+nY=; b=JKZEa1O7AyDuMnjqk+xFx/C70gFXyASTFz87k2JUqr+JBIIi9jKAe/LD+nTfYpxtE1 5SsZczh6UkpkGdF7CboxJhZm0WKZnitOKHlGS8ZUg/XVGWT8mEoWKKSSOvoGb8bbR2Zk q9w1Jm7phhfBOEvo833L8k0m3NaWpA+IZTkGKyHVM2rR2wv21SFCRQvNOowxWurIF7uA 129O6+Vh5cy3DP2ZMTsqFPJq47gFpJdqJ85FZFPoHvN53e/SAWGyoZIsT4PGBGE895FK nV8XII4leIpA/3xGyQDxId9jkzv27LMvLGAPHI9vM0WI1+nhVY5GCzGNpXyIF+GMl6KW JF6A== X-Gm-Message-State: AOAM530SU912jMVMFW6zi2yH22l4nD6DNfN847BCNuUWsJINxCRE8t6U tieroxczb2ppvn6JV4xirPP0YMdboIJcwNBnXS8= X-Google-Smtp-Source: ABdhPJwJ8rhiO7Qku7JsBUHWk38LM62HqEk/ISql7y/o1JrPzRcBjtTzAP4umWo5F80de76qlUqhIdf4a6RmnaYW6+o= X-Received: by 2002:a17:906:6d45:: with SMTP id a5mr15141216ejt.299.1627264082038; Sun, 25 Jul 2021 18:48:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Bin.Cheng" Date: Mon, 26 Jul 2021 09:47:39 +0800 Message-ID: Subject: Re: 0001-Don-t-skip-prologue-instructions-as-it-could-affect-.patch To: Jeff Law Cc: "bin.cheng" , GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jul 2021 01:48:04 -0000 On Sat, Jul 24, 2021 at 12:30 AM Jeff Law via Gcc-patches wrote: > > > > On 7/14/2021 3:14 AM, bin.cheng via Gcc-patches wrote: > > Hi, > > I ran into a wrong code bug in code with deep template instantiation when working on sdx::simd. > > The root cause as described in commit summary is we skip prologue insns in init_alias_analysis. > > This simple patch fixes the issue, however, it's hard to reduce a case because of heavy use of > > templates. > > Bootstrap and test on x86_64, is it OK? > It's a clear correctness improvement, but what's unclear to me is why > we'd want to skip them in the epilogue either. I can only guess, there is nothing to initialize epilogue for because no code follows. Thanks, bin > > Jeff