On Tue, Nov 10, 2015 at 6:06 PM, Bernd Schmidt wrote: > On 11/10/2015 09:25 AM, Bin.Cheng wrote: >>> >>> Thanks for reviewing. I haven't committed it yet, could you please >>> point out which quoted piece is so that I can update patch? > > > Sorry, I thought it was pretty obvious... > >> +{ >> + return ccand1->hash == ccand2->hash >> + && operand_equal_p (ccand1->base, ccand2->base, 0) >> + && operand_equal_p (ccand1->step, ccand2->step, 0) >> + && TYPE_PRECISION (TREE_TYPE (ccand1->base)) >> + == TYPE_PRECISION (TREE_TYPE (ccand2->base)); >> +} >> + > > > Multi-line expressions should be wrapped in parentheses so that emacs/indent > can format them automatically. Two sets of parens are needed for this. > Operators should then line up appropriately. Ah, thanks for teaching. Here is the updated patch, hoping it's correct. Thanks, bin > > > Bernd