From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61890 invoked by alias); 27 May 2015 08:47:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60649 invoked by uid 89); 27 May 2015 08:47:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f44.google.com Received: from mail-oi0-f44.google.com (HELO mail-oi0-f44.google.com) (209.85.218.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 27 May 2015 08:47:44 +0000 Received: by oifu123 with SMTP id u123so2303821oif.1 for ; Wed, 27 May 2015 01:47:41 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.111.231 with SMTP id il7mr25626283obb.15.1432716461800; Wed, 27 May 2015 01:47:41 -0700 (PDT) Received: by 10.76.134.100 with HTTP; Wed, 27 May 2015 01:47:41 -0700 (PDT) In-Reply-To: References: <55438E3F.8050205@arm.com> <55658268.7020403@arm.com> Date: Wed, 27 May 2015 09:29:00 -0000 Message-ID: Subject: Re: [PATCH][ARM] Add debug dumping of cost table fields From: "Bin.Cheng" To: Andrew Pinski Cc: Kyrill Tkachov , GCC Patches , Ramana Radhakrishnan , Richard Earnshaw Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg02400.txt.bz2 On Wed, May 27, 2015 at 4:39 PM, Andrew Pinski wrote: > On Wed, May 27, 2015 at 4:38 PM, Kyrill Tkachov wrote: >> Ping. >> https://gcc.gnu.org/ml/gcc-patches/2015-05/msg00054.html > > This and the one in AARCH64 is too noisy. Can we have an option to > turn this on and default to turning them off. Agreed. Actually I once file a PR about this enormous dump information in gimple dumps. Thanks, bin > > Thanks, > Andrew > >> >> Thanks, >> Kyrill >> >> On 01/05/15 15:31, Kyrill Tkachov wrote: >>> >>> Hi all, >>> >>> This patch adds a macro to wrap cost field accesses into a helpful debug >>> dump, >>> saying which field is being accessed at what line and with what values. >>> This helped me track down cases where the costs were doing the wrong thing >>> by allowing me to see which path in arm_new_rtx_costs was taken. >>> For example, the combine log might now contain: >>> >>> Trying 2 -> 6: >>> Successfully matched this instruction: >>> (set (reg:SI 115 [ D.5348 ]) >>> (neg:SI (reg:SI 0 r0 [ a ]))) >>> using extra_cost->alu.arith with cost 0 from line 10506 >>> >>> which can be useful in debugging the rtx costs. >>> >>> Bootstrapped and tested on arm. >>> >>> Ok for trunk? >>> >>> Thanks, >>> Kyrill >>> >>> >>> 2015-05-01 Kyrylo Tkachov >>> >>> * config/arm/arm.c (DBG_COST): New macro. >>> (arm_new_rtx_costs): Use above. >> >>