From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-413431-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 12918 invoked by alias); 10 Nov 2015 01:26:35 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 12905 invoked by uid 89); 10 Nov 2015 01:26:34 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-vk0-f41.google.com
Received: from mail-vk0-f41.google.com (HELO mail-vk0-f41.google.com) (209.85.213.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 10 Nov 2015 01:26:32 +0000
Received: by vkbk63 with SMTP id k63so4525839vkb.0        for <gcc-patches@gcc.gnu.org>; Mon, 09 Nov 2015 17:26:30 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.31.3.139 with SMTP id f11mr626213vki.7.1447118790809; Mon, 09 Nov 2015 17:26:30 -0800 (PST)
Received: by 10.103.45.207 with HTTP; Mon, 9 Nov 2015 17:26:30 -0800 (PST)
In-Reply-To: <5640BAAB.3010709@redhat.com>
References: <000901d116ea$19388d70$4ba9a850$@arm.com>	<CAFiYyc1UTfA1pHQ+QSRBmO6SF0Xfu9Gs5kmKurDWryowY9=RTg@mail.gmail.com>	<CAHFci291ZFYgYAKLmm3WecnBzRoJNiKgnbYg3K2XYCGyBWGWQQ@mail.gmail.com>	<35546C22-9163-4D5F-A8D8-76E4F16C3B30@gmail.com>	<5640BAAB.3010709@redhat.com>
Date: Tue, 10 Nov 2015 01:26:00 -0000
Message-ID: <CAHFci2_m8ZjpSs=1=OihufNCb9no1gfUMvHHaFdBp98tb_0irA@mail.gmail.com>
Subject: Re: [PATCH PR52272]Be smart when adding iv candidates
From: "Bin.Cheng" <amker.cheng@gmail.com>
To: Bernd Schmidt <bschmidt@redhat.com>
Cc: Richard Biener <richard.guenther@gmail.com>, Bin Cheng <bin.cheng@arm.com>, 	GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-11/txt/msg01147.txt.bz2

On Mon, Nov 9, 2015 at 11:24 PM, Bernd Schmidt <bschmidt@redhat.com> wrote:
> On 11/08/2015 10:11 AM, Richard Biener wrote:
>>
>> On November 8, 2015 3:58:57 AM GMT+01:00, "Bin.Cheng"
>> <amker.cheng@gmail.com> wrote:
>>>>
>>>> +inline bool
>>>> +iv_common_cand_hasher::equal (const iv_common_cand *ccand1,
>>>> +                          const iv_common_cand *ccand2)
>>>> +{
>>>> +  return ccand1->hash == ccand2->hash
>>>> +        && operand_equal_p (ccand1->base, ccand2->base, 0)
>>>> +        && operand_equal_p (ccand1->step, ccand2->step, 0)
>>>> +        && TYPE_PRECISION (TREE_TYPE (ccand1->base))
>>>> +             == TYPE_PRECISION (TREE_TYPE (ccand2->base));
>>>>
>> Yes.  Patch is OK then.
>
>
> Doesn't follow the formatting rules though in the quoted piece.

Hi Bernd,
Thanks for reviewing.  I haven't committed it yet, could you please
point out which quoted piece is so that I can update patch?

Thanks,
bin
>
>
> Bernd
>