public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Bin.Cheng" <amker.cheng@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/3] Run profile feedback tests with autofdo
Date: Thu, 14 Jul 2016 11:06:00 -0000	[thread overview]
Message-ID: <CAHFci2_oL+Nu5Rh2X9RMzhHQ-iFbQC78YNunpMsJ6tmZP-HgXw@mail.gmail.com> (raw)
In-Reply-To: <20160714105512.GE5871@two.firstfloor.org>

On Thu, Jul 14, 2016 at 11:55 AM, Andi Kleen <andi@firstfloor.org> wrote:
>> After this patch, I got below test results with command line: make
>> check-gcc RUNTESTFLAGS="tree-prof.exp" -k
>
> That is expected if you don't have autofdo. You would prefer to hide it?
>
>> Also I got unstable test result in tree-prof.exp if I run
>> aforementioned command line with -jnum (parallelly).  Does the patch
>> has problem in parallel testing?
>
> I haven't seen that. Unstable in what way?
For GCC doesn't support FDO, it run below tests as you said:

PASS: gcc.dg/tree-prof/20041218-1.c compilation,  -g
UNSUPPORTED: gcc.dg/tree-prof/20041218-1.c: Cannot run create_gcov
--binary /data/work/trunk/build/gcc/testsuite/gcc/20041218-1.gcda

Normally, it doesn't create gcov data file, thus the next test is
unsupported.  I guess in parallel test, the second test picks up gcov
data files from other process, which results in random pass.
Is it possible to not have these when fdo is supported?

Thanks,
bin

>
> -Andi

  reply	other threads:[~2016-07-14 11:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23 14:37 Committed version of autofdo testing&building patches Andi Kleen
2016-06-23 14:38 ` [PATCH 1/3] Add gcc-auto-profile script Andi Kleen
2016-06-23 14:38   ` [PATCH 2/3] Run profile feedback tests with autofdo Andi Kleen
2016-07-12 15:13     ` Bin.Cheng
2016-07-14 10:55       ` Andi Kleen
2016-07-14 11:06         ` Bin.Cheng [this message]
2016-07-14 11:08           ` Bin.Cheng
2016-07-14 22:33             ` Andi Kleen
2016-07-15  8:37               ` Bin.Cheng
2016-07-15 19:44                 ` Jeff Law
2016-07-15 20:53                   ` Andi Kleen
2016-07-25 11:08                 ` Martin Liška
2016-07-26  4:21                   ` Andi Kleen
2016-07-26  4:25                     ` Jeff Law
2016-07-26  4:28                       ` Andi Kleen
2016-07-27  8:29                         ` Martin Liška
2016-07-27 20:20                         ` Jeff Law
  -- strict thread matches above, loose matches on Subject: below --
2016-06-22 12:37 [PATCH 1/3] Add gcc-auto-profile script Andi Kleen
2016-06-22 12:37 ` [PATCH 2/3] Run profile feedback tests with autofdo Andi Kleen
2016-06-22 17:28   ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHFci2_oL+Nu5Rh2X9RMzhHQ-iFbQC78YNunpMsJ6tmZP-HgXw@mail.gmail.com \
    --to=amker.cheng@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).