From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122036 invoked by alias); 27 Nov 2015 03:54:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 122003 invoked by uid 89); 27 Nov 2015 03:54:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vk0-f50.google.com Received: from mail-vk0-f50.google.com (HELO mail-vk0-f50.google.com) (209.85.213.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 27 Nov 2015 03:54:10 +0000 Received: by vkbs1 with SMTP id s1so62376383vkb.1 for ; Thu, 26 Nov 2015 19:54:08 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.31.58.74 with SMTP id h71mr42004690vka.151.1448596448191; Thu, 26 Nov 2015 19:54:08 -0800 (PST) Received: by 10.103.45.207 with HTTP; Thu, 26 Nov 2015 19:54:08 -0800 (PST) In-Reply-To: <565774DC.5020808@suse.cz> References: <565774DC.5020808@suse.cz> Date: Fri, 27 Nov 2015 07:03:00 -0000 Message-ID: Subject: Re: [PATCH 7/N] Fix newly introduced memory leak in tree-ssa-loop-ivopts.c From: "Bin.Cheng" To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: gcc-patches List , Bin Cheng Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg03306.txt.bz2 On Fri, Nov 27, 2015 at 5:08 AM, Martin Li=C5=A1ka wrote: > Hi. > > There's one more patch that fixes really of lot memory leaks related to l= oop > ivopts. > The regression was introduced by r230647. > > Patch was tested in the series with the rest and the compiler bootstraps > successfully. > > Ready for trunk? Hi Martin, Thanks for fixing my issue. The IVO part of patch is OK. Just for me to understand, iv_common_cand is freed via free_ptr_hash, and thus typed_free_remove. So what leaks is the iv_use * vector in struct iv_common_cand, right? I did forget to free that. BTW, how do you monitor memory use in GCC, maybe I can run same test for my future patches. Thanks, bin