From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5335 invoked by alias); 14 Jun 2012 16:54:51 -0000 Received: (qmail 5267 invoked by uid 22791); 14 Jun 2012 16:54:48 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-gg0-f175.google.com (HELO mail-gg0-f175.google.com) (209.85.161.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Jun 2012 16:54:26 +0000 Received: by ggnp4 with SMTP id p4so1604820ggn.20 for ; Thu, 14 Jun 2012 09:54:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.50.208.34 with SMTP id mb2mr13454130igc.5.1339692865541; Thu, 14 Jun 2012 09:54:25 -0700 (PDT) Received: by 10.231.67.13 with HTTP; Thu, 14 Jun 2012 09:54:25 -0700 (PDT) In-Reply-To: References: Date: Thu, 14 Jun 2012 17:03:00 -0000 Message-ID: Subject: Re: debug insns in SMS From: Ayal Zaks To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-06/txt/msg00944.txt.bz2 Thanks for the duplicate ping. This is fine. So this indeed solves the discrepancy between running SMS w/ and w/o debugg= ing? Please include a comment next to the code stating why it's important not to create such deps. You may also want to store the result of "DEP_PRO (dep)" in src_ and use it twice, for clarity. Thanks, Ayal. On Thu, Jun 14, 2012 at 1:00 AM, Alexandre Oliva wrote: > > Apologies for the duplicate ping, this one is now properly addressed to > the pass maintainer. > > On Apr =C2=A09, 2012, Alexandre Oliva wrote: > > > On May =C2=A04, 2011, Revital1 Eres wrote: > >> Hello Alexandre > >>> I think this will restore proper functioning to SMS in the presence of > >>> debug insns. =C2=A0A while ago, we'd never generate deps of non-debug= insns > >>> on debug insns. =C2=A0I introduced them to enable sched to adjust (re= set) > >>> debug insns when non-debug insns were moved before them. =C2=A0I beli= eve it > >>> is safe to leave them out of the SCCs. =C2=A0Even though this will en= d up > >>> causing some loss of debug info, that's probably unavoidable, and the > >>> end result after this change is pobably the best we can hope for. > >>> =C2=A0Your > >>> thoughts? > > >> Thanks for the patch! > > >> I actually discussed this issue with Ayal yesterday. > >> Ayal also suggested to reconsider the edges that are created in > >> the DDG between real instructions and debug_insns. Currently, we create > >> bidirectional anti deps edges between them. This leads to the problem > >> you > >> were trying to solve in the current patch (described below) where these > >> extra edges influence the construction of the strongly connected > >> component > >> and the code generated with and w\o -g. Your patch seems to solve this > >> problem. > >> However I can not approve it as I'm not the maintainer (Ayal is). > > > Ping? > > > (Retested on x86_64-linux-gnu and i686-pc-linux-gnu) > > > > for =C2=A0gcc/ChangeLog > > from =C2=A0Alexandre Oliva =C2=A0 > > > =C2=A0 =C2=A0 =C2=A0 * ddg.c (build_intra_loop_deps): Discard deps of n= ondebug on > > debug. > > Ping? =C2=A0http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00419.html > > -- > Alexandre Oliva, freedom fighter =C2=A0 =C2=A0http://FSFLA.org/~lxoliva/ > You must be the change you wish to see in the world. -- Gandhi > Be Free! -- http://FSFLA.org/ =C2=A0 FSF Latin America board member > Free Software Evangelist =C2=A0 =C2=A0 =C2=A0Red Hat Brazil Compiler Engi= neer