From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24242 invoked by alias); 11 Apr 2012 03:15:39 -0000 Received: (qmail 24230 invoked by uid 22791); 11 Apr 2012 03:15:38 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-pb0-f47.google.com (HELO mail-pb0-f47.google.com) (209.85.160.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Apr 2012 03:15:24 +0000 Received: by pbcum15 with SMTP id um15so695531pbc.20 for ; Tue, 10 Apr 2012 20:15:24 -0700 (PDT) Received: by 10.68.225.39 with SMTP id rh7mr34064284pbc.104.1334114124209; Tue, 10 Apr 2012 20:15:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.73.71 with HTTP; Tue, 10 Apr 2012 20:15:04 -0700 (PDT) In-Reply-To: References: From: Laurynas Biveinis Date: Wed, 11 Apr 2012 03:15:00 -0000 Message-ID: Subject: Re: [PATCH 03/11] Fix PCH crash on GTYed pointer-to-scalar field of a To: Dodji Seketeli Cc: GCC Patches , Tom Tromey , Jason Merrill , Gabriel Dos Reis Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-04/txt/msg00585.txt.bz2 2012 m. balandis 10 d. 18:08, Dodji Seketeli ra=C5=A1=C4= =97: > gcc/ > > =C2=A0 =C2=A0 =C2=A0 =C2=A0* gengtype.c (write_types_process_field): =C2= =A0Force second argument > =C2=A0 =C2=A0 =C2=A0 =C2=A0of the call to the PCH object hierarchy walker= to be 'x'. I guess it'd be better if we separated prev_val[3] and constant "x" uses to separate walk_type_data fields, and I'm not sure if the fix is complete (well it is for the current usage, isn't it), but the patch is certainly OK. Thank you. --=20 Laurynas