From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by sourceware.org (Postfix) with ESMTPS id 9341D3857002; Fri, 28 Aug 2020 07:16:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9341D3857002 Received: by mail-il1-x142.google.com with SMTP id j9so62452ilc.11; Fri, 28 Aug 2020 00:16:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wxKkF5Zrj23dpFmNhgoAvn8icNntk58oiMDyfvvjSlc=; b=G7dn9DSfaHxTzAjCjPliFWhrg987WmsNwt/1gYZlPk2RXr4p1Sf9YwnFCJjj4mQn1S T/n9E54TlVEMRhsfGpbBiusgWUpNdd11jJti1HMNs9LTTXDkPljpMqiQAsu2CLmm7E6j n/rGICCLfjeF2ck0nLVelpTagmyt2bxWCqOhdRKYc2XCv7Xk5/CPRvgSAblJVugyU0Zk Rp3BzJhokeBxqyNO/WvI+WP6594AzxR6rENB+Fx0gBeHk9FsmhbYEK+SSrKUODa4OT18 pEaUMVAkH9xq4giuz/ykZ6ujhgvlZXq9jbEEn3Uj3uTnJRxejdV9+lQvz6sj1LSUdlhW sI9Q== X-Gm-Message-State: AOAM530JT3WEeoQBm/FaRxGvFBucuUzoxvlx9Y8Sv0BEIOGdwJQFA+Tg R8MZSKdjWTRs7f6jGD3Pc98QBExmBgahJelcj5E= X-Google-Smtp-Source: ABdhPJweCA8diMYtpmx8e/+tAXnLvj+60IHERB2x2rgjbPWP+X1rpJNs5WG7TxH5GV38WA54qTK9as3hBXRToBf5hBI= X-Received: by 2002:a05:6e02:c2e:: with SMTP id q14mr462732ilg.286.1598599012037; Fri, 28 Aug 2020 00:16:52 -0700 (PDT) MIME-Version: 1.0 References: <20200824113821.GA618751@redhat.com> In-Reply-To: From: =?UTF-8?Q?Krystian_Ku=C5=BAniarek?= Date: Fri, 28 Aug 2020 09:16:41 +0200 Message-ID: Subject: Re: [PATCH] libstdc++: remove an ignored qualifier on function return type To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 07:16:55 -0000 Actually ChangeLog also uses tabs, so it should be: libstdc++-v3/ChangeLog: * include/std/variant: Fix -Wignored-qualifiers in system headers. On Fri, 28 Aug 2020 at 08:55, Krystian Ku=C5=BAniarek < krystian.kuzniarek@gmail.com> wrote: > > So then you need to produce a changelog entry by hand. > I had this problem on some old Ubuntu 18.04. Anyway, here's new ChangeLog= : > > libstdc++-v3/ChangeLog: > > * include/std/variant: Fix -Wignored-qualifiers > in system headers. > > > >That doesn't test this header at all. > It does but indirectly. What I meant by manual test was: > ${GCC_GIT} -E contains_only_stdcpp_include.cpp > preprocessed.cpp > ${GCC_GIT} -Wall -Wextra -pedantic -fsyntax-only preprocessed.cpp > By manipulating GCC_GIT variable to trunk GCC and patched GCC, I checked > if the warning is gone. > > >What about the libstdc++ testsuite? > I hope you mean calling make bootstrap and make check. If that's ok, I > confirm it works on Manjaro and Ubuntu 18.04 with gcc10 and gcc8 > respectively. > > >I don't remember exactly why I put it there, but I seem to recall it > >was necessary. > I don't know your reasons but I can only tell that this patch seems to > compile and work just fine. > > On Mon, 24 Aug 2020 at 13:38, Jonathan Wakely wrote: > >> On 24/08/20 13:26 +0200, Krystian Ku=C5=BAniarek via Libstdc++ wrote: >> >Hi, >> > >> >First of all, sorry, I must have sent it as quoted-printable so spaces >> and >> >tabs are preserved. >> > >> >A description of the problem/bug and how your patch addresses it: >> >I've got a small patch for -Wignored-qualifiers in system headers. >> > >> >Testcases: >> >N/A, it's only a warning. >> > >> >ChangeLog: >> >Sorry, contrib/mklog.py didn't quite work for me. >> >For some reason after instruction in line 129: "diff =3D PatchSet(data)= " my >> >"diff" variable is always empty. >> >> So then you need to produce a changelog entry by hand. >> >> >Bootstrapping and testing: >> >Tested that manually by recompling GCC, unfolding all headers with >> >`#include ` and compiling what's been included by it. >> >> That doesn't test this header at all. >> >> What about the libstdc++ testsuite? >> >> >The patch itself: >> > >> >diff --git a/libstdc++-v3/include/std/variant >> b/libstdc++-v3/include/std/variant >> >index eb3d6779205..e8fcb57a401 100644 >> >--- a/libstdc++-v3/include/std/variant >> >+++ b/libstdc++-v3/include/std/variant >> >@@ -808,7 +808,7 @@ namespace __variant >> > { using element_type =3D _Tp; }; >> > >> > template >> >- struct __untag_result >> >+ struct __untag_result >> >> I don't remember exactly why I put it there, but I seem to recall it >> was necessary. >> >> >> > : false_type >> > { using element_type =3D void(*)(_Args...); }; >> > >> > >> > >> >Best regards, >> >Krystian >> > >> >>