From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id A0AD03858C3A for ; Sat, 1 Jun 2024 05:37:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A0AD03858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A0AD03858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717220245; cv=none; b=FGMnl3bYux+cYZI9DuryLA2zu/tm6wOyrzZZnJcurWUqhZ4olrulyAg3XRqV76RWnkTovAbq0RpX0Pcy2vyfqh+gWbVri6lHfsFlaM15cWJVrvs5cHwMWDC3K/RyxCEpIkWZN+KxsXbaMEH1JUnquLnAg+9I8d4+T5g8B25GMlQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717220245; c=relaxed/simple; bh=LrRS7JXzTxI6da2G4mDX2aBKdwWmxaQYjLRqdsMeYq8=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=K9AqmyDRSJLGJEr+2Y2uwJorIt8Xka8z2Rt1iWjYX5HPvD/dy1EMTayLDIrj5ijPk4EdpVr1+vASjk6GdNvR2m/z8J3WVu28oys8yi23k+EMcGR71c5VRLOwb5kamtyBVxzBUDRou7npqKzZhJuneCO9ISCS3Rdg2fRDteo3pfA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-57a30b3a6cbso1999711a12.1 for ; Fri, 31 May 2024 22:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1717220241; x=1717825041; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=43WGplPqbJ6RxDT1RSr1JQflXi2uWTwlY0y4PVs+puM=; b=2A5VkYYXRwEro1IEuXb1/QDSjngkezFSk9tCiuyCpHZ8ZnxvmjCxtpEp1CAzYeho75 gsbvnEIctFE1v29glmF9XGSZK9j5bTOcrvkErRyPU0wAn2hYPctqY0e7haQF50l6b0rv CdvO/JNarXI3uM40GqaspqyC9JWIVo8u+po7w4AROxxdKZiyReknLSETJa/Wdb/5jfRZ B1ABZ6uzREiS+P8UwZyzdK4jaw25T9NbI3LSf4f4/EFscFE0BMhuNsGwJhzgy3cKsROj Z8SshfKI5/aboij8rAVSPnMmh5U0pniXvJ4T9ALISdj23OvNUdMg+26GyebTSCIW2ZtI wREA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717220241; x=1717825041; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=43WGplPqbJ6RxDT1RSr1JQflXi2uWTwlY0y4PVs+puM=; b=BsDr4Px5YdCK2sPf4vPtdCIavDBpX1U2gaEHYzxeY0sSdHcwT56AtDmX2XMOZqucc9 T1OPhqUdQUz041buHYiYBQzhiTMBbWFFwMc8tifWII8oBVlQvkchn7HJNR2KN7cIeunJ VglIySMFQLLG/xWrZzptUYjC2WD8M4tgyQpjNIiO8f9gmU4vW1v92CDNJCyUKya/NG+N +HE4YX7kHmoXdNYGbuiI6y5tVWZL22ijlOgzG5r67qiqvFjMMvEDo8l5vyWhUeXl9wAp jNKLNIXonaCgV1f2JDms4wDeUvfbILnRkoCRwxl2sRkOnKJbegG4qYEzJgwtLX3TtEom jAMA== X-Forwarded-Encrypted: i=1; AJvYcCWAYN9/tMWzEdpfBoC1x6BD5inBfXZNBUFLZqFf0/evWooZeY+84RXD03CkmX0LtvZ655emvvlqIBTQYI1uFA+52Q5Jg1HKBQ== X-Gm-Message-State: AOJu0Yyn1y94dkJoLpyW5BSHJRRqrvkbdph1RweHsyMQ/c8P4PxOiuhz rC1XkJIy9gSqAM731iQa8UZCpkH7oT/2rtpxwBUW7eQPXIp4qsGMs9K8stuel0Tae8N7E/WZOlP JfEWKxBzGkgc5NaxfWHTs9ZHP8oOdEx2/cdVvYA== X-Google-Smtp-Source: AGHT+IHh5hEHUSF/5BFBaH6FG8RMrIF8jk+SWy7IhtaezQPGNNZURixsmnKJGT7IwiN2kMCmbmzWIovXMCvGN9x8ido= X-Received: by 2002:a17:906:600a:b0:a66:7b79:3572 with SMTP id a640c23a62f3a-a681fc5bfb9mr214370966b.15.1717220241059; Fri, 31 May 2024 22:37:21 -0700 (PDT) MIME-Version: 1.0 References: <20240531134404.12930132C2@imap1.dmz-prg2.suse.org> <76bc5ed5-c6e0-423b-ace9-3f2a78d58474@gmail.com> In-Reply-To: <76bc5ed5-c6e0-423b-ace9-3f2a78d58474@gmail.com> From: "Patrick O'Neill" Date: Fri, 31 May 2024 22:37:09 -0700 Message-ID: Subject: Re: [PATCH 5/5][v3] RISC-V: Avoid inserting after a GIMPLE_COND with SLP and early break To: Jeff Law Cc: Richard Biener , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, May 31, 2024 at 9:41=E2=80=AFPM Jeff Law wr= ote: > > On 5/31/24 7:44 AM, Richard Biener wrote: > > When vectorizing an early break loop with LENs (do we miss some > > check here to disallow this?) we can end up deciding to insert > > stmts after a GIMPLE_COND when doing SLP scheduling and trying > > to be conservative with placing of stmts only dependent on > > the implicit loop mask/len. The following avoids this, I guess > > it's not perfect but it does the job fixing some observed > > RISC-V regression. > > > > * tree-vect-slp.cc (vect_schedule_slp_node): For mask/len > > loops make sure to not advance the insertion iterator > > beyond a GIMPLE_COND. > Note this patch may depend on others in the series. I don't think the > pre-commit CI tester is particularly good at handling that, particularly > if the other patches in the series don't have the tagging for the > pre-commit CI. > > What most likely happened is this patch and only this patch was applied > against the baseline for testing. I fixed that last week (5/16) so we shouldn't be seeing that issue anymore. If you're still seeing it please let me know and I'd be interested to dig i= n. >From checking the patch_urls artifact it looks like all 5 patches were appl= ied to 46d931b. It's an old baseline so that might be the issue. We've been having hard-to-diagnose network issues on some of the newly-added CI boxes. Fingers crossed that's resolved now. I'll rerun this patch tomorrow once the new baseline is generated. > There are (manual) ways to get things re-tested. I'm hoping Patrick and > Edwin automate that procedure relatively soon. Until that happens you > have to email patchworks-ci@rivosinc.com with a URL for the patch in > patchwork that you want retested. Ditto - treat it as if it's automated. When I see it I'll reply with a link to the rerun. I'll start to look at wiring it up to an automation next week. I also have the ability to manually trigger on patches not labelled 'RISC-V= ' so feel free to ping for that as well. Patrick > Jeff >