From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id C1AC53858D39 for ; Mon, 27 Mar 2023 10:12:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1AC53858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52f.google.com with SMTP id eg48so33624944edb.13 for ; Mon, 27 Mar 2023 03:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679911920; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HcHQdaODYsLNOWUvaOH/TUi+Z6QVG/sO2/nFwXFbMWE=; b=Jkb6//MlkjItSGzZVI0Uk0HRaHko1gqGnoh4T/B4A0fcpTCnYxye8/x4MxaxYJQVfr MkgmJMZYiKtxjcwjgvpxd4u6c1tbJ3yhZDJ76gug4pCyI2gIOd/JGXy5cARkXajF6YY3 Mav8lhZ+Y4ZfHmMk4DKG9If4HbyKn0W+LKuuvtxXqLWO5qs9Dg8FvJXQA2yHpIyL/xg+ EpyVOwb53rsps87PuQwh2XKiq0TqNdejW0Cz4D2nz1CuKjAgkuNUCYC+PO0w6Sjiiy7j fxS7T90ov+5P/kfD936jTj/0GryrrEqH8PFvQs0rI3WvBIl+xsqT4JESQfK6JVr3atgA rySg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679911920; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HcHQdaODYsLNOWUvaOH/TUi+Z6QVG/sO2/nFwXFbMWE=; b=NMhIQjRF+zf5Opm86AaTJ0idAIab15ImMb9y4U3DfX4kxijDpU2Ii4rxG2FyqtvLYz LIPRsxSIszwpfIcebFXQ6npZkg7SV09PKu3Lnjo935OPzurWYmUzkJ1Qz3/vgrkKuw6K 0b5hcx5dIFiD0pexTys0kpcTBRR6TLxjDa8BssJff/3yww7ZnRaVPhvHG8ULnZasjWMn z46kHO6R/U6FVjW8iVnwxmVN8j5ZpiANjql7cNDiOF/beNigArD2GIdSznbLCchKtjho l1JHmBpzPN7zBqo+7l7+leFX8kNFtQLPn3A6Piq+pOpJSqlMMN0294HWsRraKZkiGAY7 dhiQ== X-Gm-Message-State: AAQBX9cUlmX1mC1jDkij0N6O7otxTDX/w8Hreky0Qa0qeeseBTIPveBm EKjb9xUPjbkg0g58HccFNN4CYV2Q9aSOuL4nQP0= X-Google-Smtp-Source: AKy350YgLiUQlTEQ2XNd6DeT459R7qYILu6JvBEOGYYRDBKXWwlchV6ZmIItQ9zBVD5SeQOTm6f5mo76MkWqTKVubl0= X-Received: by 2002:a17:907:d02:b0:931:6921:bdbb with SMTP id gn2-20020a1709070d0200b009316921bdbbmr5184875ejc.2.1679911920461; Mon, 27 Mar 2023 03:12:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Costas Argyris Date: Mon, 27 Mar 2023 11:11:49 +0100 Message-ID: Subject: Re: [PATCH] driver: Treat include path args the same way between cpp_unique_options and asm_options. [PR71850] To: Xi Ruoyao Cc: gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="00000000000045ea7d05f7def96f" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000045ea7d05f7def96f Content-Type: text/plain; charset="UTF-8" Would it be possible to make it version-dependent, then? As in, if GNU assembler is greater or equal to the version that supports @FILE, then pass @FILE to it, otherwise fall back to the current behavior. I assume most people nowadays would have a version of Binutils later than 2005, but if we could make it conditional on the version then even those with earlier version wouldn't break, they would just get the current behavior. On Mon, 27 Mar 2023 at 11:00, Xi Ruoyao wrote: > On Mon, 2023-03-27 at 10:36 +0100, Costas Argyris via Gcc-patches wrote: > > [ping^3] > > > > This looks like it fixes the bug and also unifies the way include paths > are > > passed from the driver to the compiler and assembler (when a @file has > > been passed to the driver in the first place). > > > > That is, when @file has been passed to the driver, put the include paths > > in a temp @file and pass them to the assembler. Note this is already > > happening for the compiler, so this patch merely extends this logic to > the > > assembler. > > > > Is there any reason not to go for it? > > It's not supported by all GNU assembler releases. For example, GCC > installation doc says we require Binutils >= 2.13.1 for i?86-*-linux*. > Binutils 2.13.1 was released in 2002, but @FILE support was added into > Binutils in 2005. > > > > > -- > Xi Ruoyao > School of Aerospace Science and Technology, Xidian University > --00000000000045ea7d05f7def96f--