From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 5446E3858D3C for ; Wed, 6 Dec 2023 14:29:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5446E3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5446E3858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701872979; cv=none; b=UuPdxVIUSit+SGyIhMccwV7PjBtOX48/PFOQUGAOE7oxlwB79K/xlIqIXyQ3TH8ZxEwmL7sP6M7RbhfgNnONyuBkrBj6wOWEAnd/zZZOjO7v6xcI+cCwkqF7ykGXaZ82hRuhVEqWatkB/6/zUncO2FSIygK6UB8GmzDZrg7qPLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701872979; c=relaxed/simple; bh=/Tb51b8mVVoQN9oEr+4pHU5PquxEYXXQ5cKcqNthMkg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ZoOREqn4b0OuR5qg0FZleRqEet8dGEY7fGDUWd/Ut4oijfBGmUMKdshrG/91b1dtk94KLh+G5mDHmBmK3choBxNPeCkGHwn5VSqeY0zdhVeNxjrcD/V9bWthk7f+y61shd1IsDaNFAMC+ZTIIe1l2W/KNzuOnhHUe7ufogw8RGs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40c09d0b045so42592265e9.0 for ; Wed, 06 Dec 2023 06:29:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701872977; x=1702477777; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qj9gc+RrUgL05QbecbJZr1gZ+U4Eg9lxG5q2dPpPXP0=; b=asYaxuoyPheKPFqKwfO0jWdWmWup5hcE9IpLurmh6PYdknQtlN6LmN5SNPi+RsGYov YAU+6/ktdQrECek3gCUA9LRbMLpfBLxRH5oirKlg0fJ3Z7NwELm8iDgHCqxS6VjEmK3g iECqcf/CO9otLBSShnIaLr5rTDutk33SiEfrWLF/AYrKBy2B9lFa4NdhFE7KC5Yih3rS uWbz8GDIq8Nq1CM/oT4aHa5sm7MqPQ0EVzOuJXU6QbFtsOkE+R4KTQfumTLfQkcbC6RD FVi8TbOPAsL8UzRt4jWoovYErRQSU/rTO6lSkqRXp+NYYS9rTE2O4wjOlz87AGaEfKkG 4wMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701872977; x=1702477777; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qj9gc+RrUgL05QbecbJZr1gZ+U4Eg9lxG5q2dPpPXP0=; b=NpvaICnIwY4/YmKmaYISL10qmA1saMEr1ANZD0cll2+2Fb+I9X0eD7ZSmc7RXmuYqI ETxeaKFr6afEatBogiliKOA94RKVFhwWCO2nFqxzT9T7XPNVGTKqzjlXLCaTP3Md9WiM iRS/DohPfAdd+f3ZgnoDI/IzsicRi9tU+GWPzp6ZPc0uz1H9RVPk4yp2zzpuFyGTx69Y 8j5uPBTxhwsoJRv41c8e+BwNLUCbJs9ze7Me+vJw9YbdRuNryFzCaonQcyDtELGVAGhz awFPyYDXv9F1ylOKNSsMNTnAhBe3plboujZCTLmLbKs+Mu3lMQDwPVvxpACGEdjgQ7Or v6iw== X-Gm-Message-State: AOJu0YxpJwGxG8OKWiQdsnu1tM3TFOF8PK6ByHYxURHoc9xeAcJEvzUB Q1RQNyPh0nd/Ua18mkWoj05nLW69vOGtKwThT9Q= X-Google-Smtp-Source: AGHT+IGbMr7y4fKRiMwpEz/RIANsQBgNC8mkC3touWjHcEdQb3TZSXoGfuRqKvRGYkdl6rWa5TPvLnJUHxSO2m4CTIU= X-Received: by 2002:a05:600c:510e:b0:40c:22e2:14d1 with SMTP id o14-20020a05600c510e00b0040c22e214d1mr357702wms.12.1701872976780; Wed, 06 Dec 2023 06:29:36 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Costas Argyris Date: Wed, 6 Dec 2023 14:29:25 +0000 Message-ID: Subject: Re: [PATCH] driver: Fix memory leak. To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary="0000000000003c28a6060bd82ea3" X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000003c28a6060bd82ea3 Content-Type: multipart/alternative; boundary="0000000000003c289f060bd82ea1" --0000000000003c289f060bd82ea1 Content-Type: text/plain; charset="UTF-8" Attached a new patch with these changes. On Mon, 4 Dec 2023 at 12:15, Jonathan Wakely wrote: > On Sat, 2 Dec 2023 at 21:24, Costas Argyris wrote: > > > > Use std::vector instead of malloc'd pointer > > to get automatic freeing of memory. > > You can't include there. Instead you need to define > INCLUDE_VECTOR before "system.h" > > Shouldn't you be using resize, not reserve? Otherwise mdswitches[i] is > undefined. > > --0000000000003c289f060bd82ea1-- --0000000000003c28a6060bd82ea3 Content-Type: application/octet-stream; name="0001-driver-Fix-memory-leak.patch" Content-Disposition: attachment; filename="0001-driver-Fix-memory-leak.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lptv6jei0 RnJvbSA2OWVjMzdiOTcyMzRmYzQ3ZTc3YjYzM2UwOTY5YzI2NDZkNGYyZTRh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDb3N0YXMgQXJneXJp cyA8Y29zdGFzLmFyZ3lyaXNAZ21haWwuY29tPgpEYXRlOiBTYXQsIDIgRGVj IDIwMjMgMjA6NTI6MDcgKzAwMDAKU3ViamVjdDogW1BBVENIXSBkcml2ZXI6 IEZpeCBtZW1vcnkgbGVhay4KClVzZSBzdGQ6OnZlY3RvciBpbnN0ZWFkIG9m IG1hbGxvYydkIHBvaW50ZXIKdG8gZ2V0IGF1dG9tYXRpYyBmcmVlaW5nIG9m IG1lbW9yeS4KClJlc3VsdCB3YXMgdmVyaWZpZWQgYnkgdmFsZ3JpbmQsIHdo aWNoIHNob3dlZApvbmUgbGVzcyBsb3NzIHJlY29yZC4KClNpZ25lZC1vZmYt Ynk6IENvc3RhcyBBcmd5cmlzIDxjb3N0YXMuYXJneXJpc0BnbWFpbC5jb20+ Ci0tLQogZ2NjL2djYy5jYyB8IDcgKysrKy0tLQogMSBmaWxlIGNoYW5nZWQs IDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9nY2MvZ2NjLmNjIGIvZ2NjL2djYy5jYwppbmRleCA5ZjIxYWQ5NDUzZS4u MjYyM2FiM2E4NTUgMTAwNjQ0Ci0tLSBhL2djYy9nY2MuY2MKKysrIGIvZ2Nj L2djYy5jYwpAQCAtMjksNiArMjksNyBAQCBjb21waWxhdGlvbiBpcyBzcGVj aWZpZWQgYnkgYSBzdHJpbmcgY2FsbGVkIGEgInNwZWMiLiAgKi8KIAogI2Rl ZmluZSBJTkNMVURFX1NUUklORwogI2luY2x1ZGUgImNvbmZpZy5oIgorI2Rl ZmluZSBJTkNMVURFX1ZFQ1RPUgogI2luY2x1ZGUgInN5c3RlbS5oIgogI2lu Y2x1ZGUgImNvcmV0eXBlcy5oIgogI2luY2x1ZGUgIm11bHRpbGliLmgiIC8q IGJlZm9yZSB0bS5oICovCkBAIC05NTM0LDcgKzk1MzUsNyBAQCBzdHJ1Y3Qg bWRzd2l0Y2hzdHIKICAgaW50IGxlbjsKIH07CiAKLXN0YXRpYyBzdHJ1Y3Qg bWRzd2l0Y2hzdHIgKm1kc3dpdGNoZXM7CitzdGF0aWMgc3RkOjp2ZWN0b3I8 c3RydWN0IG1kc3dpdGNoc3RyPiBtZHN3aXRjaGVzOwogc3RhdGljIGludCBu X21kc3dpdGNoZXM7CiAKIC8qIENoZWNrIHdoZXRoZXIgYSBwYXJ0aWN1bGFy IGFyZ3VtZW50IHdhcyB1c2VkLiAgVGhlIGZpcnN0IHRpbWUgd2UKQEAgLTk3 NTMsNyArOTc1NCw3IEBAIHNldF9tdWx0aWxpYl9kaXIgKHZvaWQpCiAgICAg ewogICAgICAgaW50IGkgPSAwOwogCi0gICAgICBtZHN3aXRjaGVzID0gWE5F V1ZFQyAoc3RydWN0IG1kc3dpdGNoc3RyLCBuX21kc3dpdGNoZXMpOworICAg ICAgbWRzd2l0Y2hlcy5yZXNpemUgKG5fbWRzd2l0Y2hlcyk7CiAgICAgICBm b3IgKHN0YXJ0ID0gbXVsdGlsaWJfZGVmYXVsdHM7ICpzdGFydCAhPSAnXDAn OyBzdGFydCA9IGVuZCArIDEpCiAJewogCSAgd2hpbGUgKCpzdGFydCA9PSAn ICcgfHwgKnN0YXJ0ID09ICdcdCcpCkBAIC0xMTM2Niw3ICsxMTM2Nyw3IEBA IGRyaXZlcjo6ZmluYWxpemUgKCkKICAgaW5wdXRfZnJvbV9waXBlID0gMDsK ICAgc3VmZml4X3N1YnN0ID0gTlVMTDsKIAotICBtZHN3aXRjaGVzID0gTlVM TDsKKyAgbWRzd2l0Y2hlcy5jbGVhciAoKTsKICAgbl9tZHN3aXRjaGVzID0g MDsKIAogICB1c2VkX2FyZy5maW5hbGl6ZSAoKTsKLS0gCjIuMzAuMgoK --0000000000003c28a6060bd82ea3--