From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id 53BFA385842C for ; Wed, 7 Jun 2023 13:07:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 53BFA385842C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-514953b3aa6so1260309a12.1 for ; Wed, 07 Jun 2023 06:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686143258; x=1688735258; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UKISldItTTNsLxYm5pKVOy8qFjSHzEKPySPDVy4DBXA=; b=LWVVbVaGvgjD8MNI7548B/26Wfb7Grmu8VH9jabP3CEWyqbrnw0npVZ+5TwW11sKkP cRtXMnN2/0ASUvUsJ7psMP7IJ2pYfn+xKMTfmVd4t2sQSMpx3Ywmvq93I2VTkanGmz1R OgeufqujOj7h3gQ7h20o3ssf17i9h4owFuC6TzlyFhhalnIfw0Aa+jPd8qvy5bNiRgcc IFlVZ0ChOAJDjccPo9JH2qf7qJTwyeYrS0YgtmU9z2Y4elbkReDRXTefrVZXqk1Is9FB wCecHLeb1tYR8R5J0r/9oF6SrxotQdHNJ0ODYK2mEgpANET2ub6EpBCtXzwFOEJWc/bD yWXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686143258; x=1688735258; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UKISldItTTNsLxYm5pKVOy8qFjSHzEKPySPDVy4DBXA=; b=c2Diy3W/RVhGelJgkMVkIm/Gy1PruOyGoZQXIsYi5LT0y0uOo8i0Uf/ezFnGO0tKyu 4YLJMeQ5ksFqdzJCr79WPzB8GHufyw4oCiNTLZof/8cvulXf1d4oqhPBSCdJGtUhQBAS OkyT7eL60ikB1S15roNDw1Y4DErzAE2q/5F+vDQc2dHBypDryqhjSv2wGXh7iEuZxcGN BpifK4yCXFNX8JKp3bDPfDmph/KA+zHozOUHemRlRc89DX3X4KIBB0ZPO4+5CEyOj6kw deCnmiubSkEpU5rwYn+qObUq/3UEjHJ71aH2EB4om8B9XbZU5TdgS+6rSXukDBSz6tL2 pzjg== X-Gm-Message-State: AC+VfDzd3pAs8f4+138eSBwjRjeKB9GQIEOVnr9IcZBkZ654hVeB9EgA kLX2yw0Yuh+fFXtVxhylx4iYXjjzAE8C0nmOM/8= X-Google-Smtp-Source: ACHHUZ7HUSqJK2Dkin0Y6Sv1Hk7HET9Ctj7kg8rCHnHXGACKq6q0FSWz8FBfYfRd/FTKyf2hCCD/W092+djxw14tp+o= X-Received: by 2002:aa7:c40f:0:b0:516:9e92:7e0e with SMTP id j15-20020aa7c40f000000b005169e927e0emr1328811edq.13.1686143257572; Wed, 07 Jun 2023 06:07:37 -0700 (PDT) MIME-Version: 1.0 References: <72e6ae5f-e921-b912-63cb-6050cdf2389b@gmail.com> In-Reply-To: <72e6ae5f-e921-b912-63cb-6050cdf2389b@gmail.com> From: Costas Argyris Date: Wed, 7 Jun 2023 14:07:26 +0100 Message-ID: Subject: Re: [PATCH] libiberty: pex-unix.c: Make pex_unix_cleanup signature always match body. To: Jeff Law Cc: gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="000000000000e878d105fd89d12c" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000e878d105fd89d12c Content-Type: text/plain; charset="UTF-8" Oh OK, thanks for the clarification. Costas On Wed, 7 Jun 2023 at 13:59, Jeff Law wrote: > > > On 6/7/23 04:21, Costas Argyris via Gcc-patches wrote: > > I saw this while working on something else: > > > > pex_unix_cleanup signature doesn't always match the > > body of the function in terms of ATTRIBUTE_UNUSED. > > If the conditional code in the body is compiled, then > > ATTRIBUTE_UNUSED isn't correct. > > > > This change makes it always match, thereby making it > > a bit cleaner IMO. > ATTRIBUTE_UNUSED is meant to be a "maybe unused" decoration. I'd just > leave it as-is. > > jeff > --000000000000e878d105fd89d12c--