From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 9ABA2385B531 for ; Mon, 27 Mar 2023 09:37:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9ABA2385B531 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x529.google.com with SMTP id er18so22077357edb.9 for ; Mon, 27 Mar 2023 02:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679909827; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=XEqDqHRmEvf7C9CCmGS1Fv5Pg0yAVgAYLyGsAOTpOdk=; b=EQ1eehL1MHrkzbgiubvweyP5MYRBYriAeItQm10aO1BQHWMWTQ4UWcYg1+qSP/ZcKu N9y84jIwG3p8UYtJ8w2IM8nt/V4B/n7o4mKedKB/vb/zyFGrwD01xz/gb83Th8iNTgdX uKzF7Ve2vHI+rwkFIi34HharXJrJR6Ok2NPa/sawPEmBKH1NnMGNQLzezoRcQnjVEKxg l+OleSlbkuQM6vvayPUEoZ5hMKm0C/r/bAT2ANqZb+4/nBDMYfhFenFBsuFsLz+FgdgT qGJD21qz6DzDawm2RjR37cSJ3tiNWLKQM13jwFp0llIUEVZ9hLpdQnVSf5GDYLx9d8ex W4SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679909827; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XEqDqHRmEvf7C9CCmGS1Fv5Pg0yAVgAYLyGsAOTpOdk=; b=jdY0vTHgP/8wFKCx4Ok9+T1jGw4v2ZF+Y5YOma33xWAbGfT3z5+fHL7Rt9kJy52w5A 70bnsnInnaTUXxNNyRow2yMGTLzThigZAxbTjhIfJl7QYKQz3TXcOnyU0f3Mjv69gILF AynbdwIrWcXRxRrOhyQciMOPy3wDD825rweyjsf80u5tbW8R742gvasDa+oYlqZzZbiQ aaVBvgsUNhivZIeYlEprDoSPNFmkXQAbN/W7coGOeyK8doDC8fAXqtt5dHAzMRLSHral YZIxC6OJ3E4Srhy3MbF8sw2R+KXYe2MviM0pCE0hg3ZmTgdPNTdUbcbOHUJTK2KFauS5 nOIw== X-Gm-Message-State: AAQBX9e8hZmIgqC0r63vn/x/MJHneVSijc8T1wGg2dpOJOxhPT1wUOel 3EnrxkkCH+ABlAAKyHtAfemivJDIfQFTBusICwGDS4Bf3ow= X-Google-Smtp-Source: AKy350a+u2RjoRDTLhUjkC3Bc5CVittJc9z1R6FATolwi8lMMSPCci8ahSBAXEQKu9wzYgqSMoDKca1XgkvqmgEPRhg= X-Received: by 2002:a50:f69e:0:b0:4fc:8749:cd77 with SMTP id d30-20020a50f69e000000b004fc8749cd77mr5511050edn.3.1679909826941; Mon, 27 Mar 2023 02:37:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Costas Argyris Date: Mon, 27 Mar 2023 10:36:55 +0100 Message-ID: Subject: Re: [PATCH] driver: Treat include path args the same way between cpp_unique_options and asm_options. [PR71850] To: gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="0000000000007d584805f7de7c9b" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007d584805f7de7c9b Content-Type: text/plain; charset="UTF-8" [ping^3] This looks like it fixes the bug and also unifies the way include paths are passed from the driver to the compiler and assembler (when a @file has been passed to the driver in the first place). That is, when @file has been passed to the driver, put the include paths in a temp @file and pass them to the assembler. Note this is already happening for the compiler, so this patch merely extends this logic to the assembler. Is there any reason not to go for it? On Mon, 20 Mar 2023 at 09:47, Costas Argyris wrote: > ping > > On Thu, 9 Mar 2023 at 13:39, Costas Argyris > wrote: > >> Pinging list and driver reviewer. >> >> Details here: >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71850 >> >> On Thu, 2 Mar 2023 at 19:25, Costas Argyris >> wrote: >> >>> This is a proposal to fix PR71850 by applying the existing logic for >>> passing include paths to cc1 to as. >>> >>> Thanks, >>> Costas >>> >> --0000000000007d584805f7de7c9b--