From: Costas Argyris <costas.argyris@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jonathan Wakely <jwakely@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] driver: Fix memory leak.
Date: Fri, 8 Dec 2023 12:18:50 +0000 [thread overview]
Message-ID: <CAHyHGCkeXFQNVmghuJ9ayb=rz02Yc=HcZXFTSXiqgAnNc97iGg@mail.gmail.com> (raw)
In-Reply-To: <ZXHtHmZzPES8nndo@tucnak>
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
Does the simple XDELETEVEC patch need any more work?
I think it just fixes a leak for the JIT case where driver::finalize is
called.
On Thu, 7 Dec 2023 at 16:04, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Dec 07, 2023 at 04:01:11PM +0000, Costas Argyris wrote:
> > Thanks for all the explanations.
> >
> > In that case I restrict this patch to just freeing the buffer from
> > within driver::finalize only (I think it should be XDELETEVEC
> > instead of XDELETE, no?).
>
> Both macros are exactly the same, but XDELETEVEC is probably better
> counterpart to XNEWVEC.
>
> Jakub
>
>
next prev parent reply other threads:[~2023-12-08 12:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 21:24 Costas Argyris
2023-12-04 12:15 ` Jonathan Wakely
2023-12-06 14:29 ` Costas Argyris
2023-12-06 14:39 ` Jakub Jelinek
2023-12-07 14:28 ` Costas Argyris
2023-12-07 14:42 ` Jakub Jelinek
2023-12-07 15:16 ` Costas Argyris
2023-12-07 15:42 ` Jakub Jelinek
2023-12-07 16:01 ` Costas Argyris
2023-12-07 16:04 ` Jakub Jelinek
2023-12-08 12:18 ` Costas Argyris [this message]
2023-12-08 13:16 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHyHGCkeXFQNVmghuJ9ayb=rz02Yc=HcZXFTSXiqgAnNc97iGg@mail.gmail.com' \
--to=costas.argyris@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jwakely@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).