From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id BB0443858C62 for ; Fri, 8 Dec 2023 12:19:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB0443858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB0443858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702037949; cv=none; b=BzvZv2l2KccLj9c0mrG9GneamKhV/eZD81qZzo9Uehe01pi+8YkT7/YkndmWKDWn0OY/otUHT+vqekk5rj0xXD6k+I6a38HsbQVPlFgJuPghPThsLg/dGm4Q5z0odRzZciCmiNLY+dPDucSBsHDi7YOcTsO1YE3P7MpvzJyI9Go= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702037949; c=relaxed/simple; bh=lUmbdk9ZTImKCYgJETQpPi7fez6Zvq7k77yy2qu/fRI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=Yskr9AwN+N17vkXwNQSORLFtq7PLHtH2EnH3OdBWKWKcctm7m2CEAoHgm7DdQnkBOHjxWXXXQJRq6aKzsRfTRrBxSnhsRnLX6WYRbipsoPqkCVHiLdoC22gn0TgJg5o+5h8WCgfRa8rFLwS+5xI1GYNgTG9vBneYirggJJ800DQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-54cd2281ccbso2666608a12.2 for ; Fri, 08 Dec 2023 04:19:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702037941; x=1702642741; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YMqLU8k7priXJYCPLB+A1gSHtPuW3watwV36roFyvlU=; b=jUPzkZxLzLXuz0zu7CS3vPttyWn+gjZTZT8hyy4Ei4OMrFaJpSDgohKn+h2Yeba3ip GqbV9hIhdK4bQK7ELz0kU8en19ZApzDHe8YEix1FXLl7e8nigMH+IciLbHoFjxMuBHqL xToFRXOpxk0TsGI3rkxFui9Msg+v3xmlxzhN/Tppp3lRSTiel9+QBms+V15dqCwLrcNx 8eKRK8zlHoVTqKnUHs2K8HKCAlvzDfszcwTaZZCc27/rvaxZsfHKFQUbh1SQdjBFH4Am 5icwa6Hqe1i5WM4lTF8+l9KZGRWHbnF025kUTpGLqseyyB7USx5tMLV+PYIsQKdBXJZg Hy4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702037941; x=1702642741; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YMqLU8k7priXJYCPLB+A1gSHtPuW3watwV36roFyvlU=; b=N6YJ/QiADstrVHazHChdJ4Qn5ExFDNcYln3AbVJk2XQnB8eXGwmn5JuT8Y77l5ztqU Ou105kBEOEfqG5scjrCiXWVh7IzHM8N1jm5hEzNLVKjLeYtL6VmVH16cIQ6PWrf0Asmm mTLKqqIe95kmuNeGfzczxrmxRtAejx9rDD7AiU0TZqA9TgY0nmitcqaYGHV2G2RdUx3C 3bsB7o2VcE2K4HKCg4EB0oh07BmWuAxSS1Yf7g3cqK7piM8Mxa7fZmNwaO9XTwWF+Z7u ib1wDzOIo1TJYGjzlMk/8WVuPhzfWNfSxu9HHT7L/0wqQ7kfaLkILHIhwfqr56lry4ii xOzw== X-Gm-Message-State: AOJu0Yz4jbzZmgeZtOkGznfP4YOmt0swH/llACIDYjYut7X8IP1QZ8bS kYW7uXQ5dCZwWmVAuuXUQ3zcakP3dc1C0HhtSog= X-Google-Smtp-Source: AGHT+IHuYHimnAxlWkSW2B/tcdBhel+j6RYZ5Nk8E3gLIt886SI35Xt0vObKeOmybkIOQAGR3yijpCfdzb5sb6DyAD4= X-Received: by 2002:a17:906:5184:b0:a19:a19b:c713 with SMTP id y4-20020a170906518400b00a19a19bc713mr2308443ejk.99.1702037941121; Fri, 08 Dec 2023 04:19:01 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Costas Argyris Date: Fri, 8 Dec 2023 12:18:50 +0000 Message-ID: Subject: Re: [PATCH] driver: Fix memory leak. To: Jakub Jelinek Cc: Jonathan Wakely , gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="000000000000dff522060bfe9670" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000dff522060bfe9670 Content-Type: text/plain; charset="UTF-8" Does the simple XDELETEVEC patch need any more work? I think it just fixes a leak for the JIT case where driver::finalize is called. On Thu, 7 Dec 2023 at 16:04, Jakub Jelinek wrote: > On Thu, Dec 07, 2023 at 04:01:11PM +0000, Costas Argyris wrote: > > Thanks for all the explanations. > > > > In that case I restrict this patch to just freeing the buffer from > > within driver::finalize only (I think it should be XDELETEVEC > > instead of XDELETE, no?). > > Both macros are exactly the same, but XDELETEVEC is probably better > counterpart to XNEWVEC. > > Jakub > > --000000000000dff522060bfe9670--