From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id CA44D3858C83 for ; Mon, 27 Mar 2023 17:18:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA44D3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52a.google.com with SMTP id y4so39273895edo.2 for ; Mon, 27 Mar 2023 10:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679937489; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HbJji85yvd+YclFbgZ0NrpBlGyNCmYBLwUETrnZnilE=; b=fL5PFsgkkanZw/NBNkB/Hb35hmq60wz3zz+sH/N7O/nrSebVg4Rvav5CF57cD1hsiT fxCMioBqqVTmACgyjlub6QvH5BnHD9+69jj94K57wYd53qfWRZmzXayRptaj9SIFtO/4 xqWmx2s4GC+obwjQxzqrU4B7uCSCm2QA8SrXLLUpwKXZxqYChMS4tnRXr9DGWrcI9Ro2 1m1ftaVwqGqfq95tPNN9r60WTUtSl1tZfWLRj/Bplz9voYcmVUlvGvaaPlFlpUaf6bKW vBTfPvjl48H7P21jbI2Mv4qD5wpTcFchiCWGwjGsaAY5rXrndpxoTIloR19mIOnq0JUB 37bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679937489; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HbJji85yvd+YclFbgZ0NrpBlGyNCmYBLwUETrnZnilE=; b=dvM48qd+v9HE3amoJt/GvdEoX9iKgSUnxsi7jB41RlOFR02bu7R3uWB4BXjhYbA7Y3 Ux41v5GMGed6wGyECzHJF+K3O3wsUT5+th8jD/KLePPP1qC4WowYC8Ql37oIt3uiiDLb C0hXNxJaKHJ4IAtl1NLUU2jcVzkxw9iqS+18hOdJVe/bVRMg1gpxPn7IrSnGXgn+tDWa 6gjXEWewpkxsFc+lzQNW4bG5uUbj5bhkhUf8kUoeUxXsajpoBFaxrIrerIk+LRXRBM5A 2RadWJzWcQOoWRWZS2eHsg/rVEP7yF2nq5SvjOcdB30xPu7WR9UCGYmp62MvIRls9Qqv sKbg== X-Gm-Message-State: AAQBX9dIwB2q7wwoZ0zi7OZ6zSglnW3fcAGT1PlMzftNMVuDwETMjguX EKFb7jXhq4PP54TOk548K0o86zAfoAc0GuJhgeukbJjMMCcIAQ== X-Google-Smtp-Source: AKy350YO1eDM9cL6yS7X6AhBOwhFgD00w56mGHbslR7UGveDUeP445QI2xGJdTDeZVtY5DbKI5b3yh4J5jCl70L7Mvk= X-Received: by 2002:a50:d6d6:0:b0:4fb:c8e3:1adb with SMTP id l22-20020a50d6d6000000b004fbc8e31adbmr6038246edj.3.1679937488665; Mon, 27 Mar 2023 10:18:08 -0700 (PDT) MIME-Version: 1.0 References: <508051a3-0314-bb4a-1ce8-5772b1b8f5a6@codeweavers.com> <002e2259-1859-1f77-ffa0-40b1b673dd4f@gmail.com> In-Reply-To: <002e2259-1859-1f77-ffa0-40b1b673dd4f@gmail.com> From: Costas Argyris Date: Mon, 27 Mar 2023 18:17:57 +0100 Message-ID: Subject: Re: Enable UTF-8 code page in driver and compiler on 64-bit mingw host [PR108865] To: gcc-patches@gcc.gnu.org Cc: Jonathan Yong <10walls@gmail.com>, Jacek Caban Content-Type: multipart/mixed; boundary="00000000000041d44205f7e4ed99" X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000041d44205f7e4ed99 Content-Type: multipart/alternative; boundary="00000000000041d44005f7e4ed97" --00000000000041d44005f7e4ed97 Content-Type: text/plain; charset="UTF-8" The patch attached to this email extends the UTF-8 support of the driver and compiler processes to the 32-bit mingw host. Initially, only the 64-bit host got it. About the changes in sym-mingw32.cc: Even though the 64-bit host was building fine with the symbol being simply declared as a char, the 32-bit host was failing to find the symbol at link time because a leading underscore was being added to it by the compiler. The asm keyword ensures that the symbol always appears with that exact name, such that the linker will always find it. The patch also includes Jacek's flag about adding the .manifest file as a prerequisite for the object file (this was actually done from before but an earlier version of the patch was pushed so it was missed). Tested building from master for both 32 and 64-bit mingw hosts using: 1) cross-compilation from a Debian machine using configure + make 2) native-compilation from a Windows machine using MSYS2 On Thu, 9 Mar 2023 at 15:03, Jonathan Yong <10walls@gmail.com> wrote: > On 3/9/23 13:33, Costas Argyris wrote: > > Pinging the list and mingw maintainer. > > > > Analysis and pre-approval here: > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108865 > > > > Thanks, pushed to master branch. > > > --00000000000041d44005f7e4ed97-- --00000000000041d44205f7e4ed99 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Extend-UTF-8-support-to-the-32-bit-mingw-host.patch" Content-Disposition: attachment; filename="0001-Extend-UTF-8-support-to-the-32-bit-mingw-host.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lfqy72td0 RnJvbSAwZWQwODczOWY0NDExNmVhZWY0NmI1NTJkZjkyMzk1OWJhOTQ1YWZh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDb3N0YXMgQXJneXJp cyA8Y29zdGFzLmFyZ3lyaXNAZ21haWwuY29tPgpEYXRlOiBTdW4sIDI2IE1h ciAyMDIzIDExOjMyOjEzICswMTAwClN1YmplY3Q6IFtQQVRDSF0gRXh0ZW5k IFVURi04IHN1cHBvcnQgdG8gdGhlIDMyLWJpdCBtaW5ndyBob3N0LgoKUHJl dmVudCBhbnkgbmFtZSBtYW5nbGluZyBpbiBIT1NUX0VYVFJBX09CSlNfU1lN Qk9MCnN1Y2ggdGhhdCB0aGUgbGlua2VyIGFsd2F5cyBmaW5kcyBpdCBieSB0 aGF0IG5hbWUuCgpBbHNvIGFkZCB0aGUgLm1hbmlmZXN0IGZpbGUgYXMgYW4g ZXhwbGljaXQKZGVwZW5kZW5jeSBpbiB0aGUgbWFrZSBydWxlIHN1Y2ggdGhh dCB0aGUKb2JqZWN0IGdldHMgcmUtYnVpbHQgaWYgaXQgY2hhbmdlcy4KLS0t CiBnY2MvY29uZmlnLmhvc3QgICAgICAgICAgICAgICAgfCA1ICsrKy0tCiBn Y2MvY29uZmlnL2kzODYvc3ltLW1pbmd3MzIuY2MgfCA0ICsrKy0KIGdjYy9j b25maWcvaTM4Ni94LW1pbmd3MzItdXRmOCB8IDMgKystCiAzIGZpbGVzIGNo YW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9nY2MvY29uZmlnLmhvc3QgYi9nY2MvY29uZmlnLmhvc3QKaW5k ZXggNGFiYjMyYWQ3M2QuLjVkZjg1NzUyZWQ0IDEwMDY0NAotLS0gYS9nY2Mv Y29uZmlnLmhvc3QKKysrIGIvZ2NjL2NvbmZpZy5ob3N0CkBAIC0yMzIsMTAg KzIzMiwxMSBAQCBjYXNlICR7aG9zdH0gaW4KICAgICA7OwogICBpWzM0NTY3 XTg2LSotbWluZ3czMiopCiAgICAgaG9zdF94bV9maWxlPWkzODYveG0tbWlu Z3czMi5oCi0gICAgaG9zdF94bWFrZV9maWxlPSIke2hvc3RfeG1ha2VfZmls ZX0gaTM4Ni94LW1pbmd3MzIiCisgICAgaG9zdF94bWFrZV9maWxlPSIke2hv c3RfeG1ha2VfZmlsZX0gaTM4Ni94LW1pbmd3MzIgaTM4Ni94LW1pbmd3MzIt dXRmOCIKICAgICBob3N0X2V4ZWV4dD0uZXhlCiAgICAgb3V0X2hvc3RfaG9v a19vYmo9aG9zdC1taW5ndzMyLm8KLSAgICBob3N0X2V4dHJhX2djY19vYmpz PSIke2hvc3RfZXh0cmFfZ2NjX29ianN9IGRyaXZlci1taW5ndzMyLm8iCisg ICAgaG9zdF9leHRyYV9vYmpzPSIke2hvc3RfZXh0cmFfb2Jqc30gdXRmOC1t aW5ndzMyLm8iCisgICAgaG9zdF9leHRyYV9nY2Nfb2Jqcz0iJHtob3N0X2V4 dHJhX2djY19vYmpzfSBkcml2ZXItbWluZ3czMi5vIHV0ZjhyYy1taW5ndzMy Lm8iCiAgICAgaG9zdF9sdG9fcGx1Z2luX3NvbmFtZT1saWJsdG9fcGx1Z2lu LmRsbAogICAgIDs7CiAgIHg4Nl82NC0qLW1pbmd3KikKZGlmZiAtLWdpdCBh L2djYy9jb25maWcvaTM4Ni9zeW0tbWluZ3czMi5jYyBiL2djYy9jb25maWcv aTM4Ni9zeW0tbWluZ3czMi5jYwppbmRleCBmMzY5Njk4YWJjNC4uMmY4ZGVl NmMxZWMgMTAwNjQ0Ci0tLSBhL2djYy9jb25maWcvaTM4Ni9zeW0tbWluZ3cz Mi5jYworKysgYi9nY2MvY29uZmlnL2kzODYvc3ltLW1pbmd3MzIuY2MKQEAg LTEgKzEsMyBAQAotY2hhciBIT1NUX0VYVFJBX09CSlNfU1lNQk9MOworLyog UHJldmVudCBhbnkgbmFtZSBtYW5nbGluZyB0byBtYWtlIHN1cmUgdGhhdCB0 aGUgbGlua2VyCisgICB3aWxsIGFsd2F5cyBmaW5kIHRoZSBzeW1ib2wuICov CitjaGFyIEhPU1RfRVhUUkFfT0JKU19TWU1CT0wgYXNtICgiSE9TVF9FWFRS QV9PQkpTX1NZTUJPTCIpOwpkaWZmIC0tZ2l0IGEvZ2NjL2NvbmZpZy9pMzg2 L3gtbWluZ3czMi11dGY4IGIvZ2NjL2NvbmZpZy9pMzg2L3gtbWluZ3czMi11 dGY4CmluZGV4IDlkZTk2M2Q3OTY1Li5jZjVjM2RiM2Q4YiAxMDA2NDQKLS0t IGEvZ2NjL2NvbmZpZy9pMzg2L3gtbWluZ3czMi11dGY4CisrKyBiL2djYy9j b25maWcvaTM4Ni94LW1pbmd3MzItdXRmOApAQCAtMjcsNyArMjcsOCBAQAog IyBUaGUgcmVzdWx0aW5nIC5vIGZpbGUgZ2V0cyBhZGRlZCB0byBob3N0X2V4 dHJhX2djY19vYmpzIGluCiAjIGNvbmZpZy5ob3N0IGZvciB4ODZfNjQtKi1t aW5ndyogaG9zdCBhbmQgZ2V0cyBsaW5rZWQgaW50bwogIyB0aGUgZHJpdmVy IGFzIGEgLm8gZmlsZSwgc28gaXQncyBsYWNrIG9mIHN5bWJvbHMgaXMgT0su Ci11dGY4cmMtbWluZ3czMi5vIDogJChzcmNkaXIpL2NvbmZpZy9pMzg2L3V0 ZjgtbWluZ3czMi5yYwordXRmOHJjLW1pbmd3MzIubyA6ICQoc3JjZGlyKS9j b25maWcvaTM4Ni91dGY4LW1pbmd3MzIucmMgXAorICAkKHNyY2RpcikvY29u ZmlnL2kzODYvd2lubnQtdXRmOC5tYW5pZmVzdAogCSQoV0lORFJFUykgJDwg JEAKIAogIyBDcmVhdGUgYW4gb2JqZWN0IGZpbGUgdGhhdCBqdXN0IGV4cG9y dHMgdGhlIGdsb2JhbCBzeW1ib2wKLS0gCjIuMzAuMgoK --00000000000041d44205f7e4ed99--