From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 6F51D3858D33 for ; Sat, 2 Dec 2023 21:24:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F51D3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F51D3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701552286; cv=none; b=J5E1vf75Cl+zgaMfCVMXtUruVbu5zYZttEoE4OdVDuK5XGWHFJMLdjxxh6INjW8+t1fC057k3pLyVEpx9zlZFEWbghrabcDIMNWhilNZhBfreU2E3UFRnAHaHtpGR0sECv5cDIl7IlQBpNWsfM3V1brcnw+bHgUeSTD7xZ3Fif0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701552286; c=relaxed/simple; bh=h006+R/PeiXpN6pRiLngbIfR2UMQVjBOEM6P6xMsuGU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=X4e0Kx84BTt23/9ngoVOXPOqvLjsyT3fjqWa43HhbS37HqggL48p0Mw40yid+n5ro217lpFEb7lILsGdg7mA4TxSiinxsHfEaas7zd762/vDIcIevztkdbeJ0AvtP8ftbzILVCkfYlF5YcIi8dh8IzKauMoxi5oBJWh3sAGrCqw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-54bf9a54fe3so4239678a12.3 for ; Sat, 02 Dec 2023 13:24:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701552284; x=1702157084; darn=gcc.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=1l0cyTpasvk5p92JOxOh1eJK60dLOX+VtBrr44rt09U=; b=N8YxITW7EJR9AsDM6/QguRT2nN7JFiHUPvLSLPIs5MNPGsSNhC21zvgQ0rQuYVMAVI SL/QVwdtYMGEzZ336XbQ4189oQlxfgNo5FopZxvtzg665Kp330rlylsgDL/YLw1k9guu /ut4j97skjk3PbxNJky6/KfmPdqCfAQ5laXqXybk4DCZXIEqybh0KOjx366UbEkCHCRH bu7Xb9coxAF8SQ1wVQSAMaa33Zw/or7iq7r1gbJpZWFXy/o1YU9IF5asVWM6ZrrbFxVI 5kv7O3qSTL12MWlPBO5Za5nJezsWwwZ7jXEBdLu5IvuI3LkXlCs37QUUNsNH/+c3JX6E dVmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701552284; x=1702157084; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1l0cyTpasvk5p92JOxOh1eJK60dLOX+VtBrr44rt09U=; b=InUM3eJKdwuGmk6xGl+9rHAbeDhJmRKvvBR2fPhS6I7CCtb2pvJRtTRm/iwZWB4MTV YoHPp0+ZB+WiYZTK0Lsi8zPQ/x6+NJZCe9vSqrqv7PMP7o4mkLURsycpTudanP2b3SfI J6b1a2sr8oJKYgHV9uy07h0ixr2tSkXlXvzMoT7q/uRWOPblmmVvKVOMxmaWfVs/0I/E kHop3FesrrTyoYfb4lfU2jA2EiQil9HBKAuQiprsHeJR85JtNgjmZ+se7z7QmLkFUfLK U1ImPpgn4DBlRs9q9fbM6M+fgYJTczODvGLkQ4Jm64AGiCxStlONaZGZfRrua2HIwqG8 EZcw== X-Gm-Message-State: AOJu0Yxmi12BVCA2pwYCd0VoquFxPgfNb4ucC1RYU/4EZJSI3SODWFvQ Tre0fJp4ABXTcvYI4PkKk8G6zPP/Rb75RkLed/T4zB/MxQc= X-Google-Smtp-Source: AGHT+IHgYYRU/QX3BhdbpZ+xgyHb38vfNvEzLJWSWQN0aYoD86UxaA+f9F8zzDSQLPBhCPuIwz0NvKzO7JUrDPdOwBc= X-Received: by 2002:a50:d511:0:b0:54c:87a2:97a2 with SMTP id u17-20020a50d511000000b0054c87a297a2mr557534edi.80.1701552283652; Sat, 02 Dec 2023 13:24:43 -0800 (PST) MIME-Version: 1.0 From: Costas Argyris Date: Sat, 2 Dec 2023 21:24:32 +0000 Message-ID: Subject: [PATCH] driver: Fix memory leak. To: gcc-patches@gcc.gnu.org, jwakely@redhat.com Content-Type: multipart/mixed; boundary="0000000000006f29e0060b8d83f1" X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000006f29e0060b8d83f1 Content-Type: multipart/alternative; boundary="0000000000006f29de060b8d83ef" --0000000000006f29de060b8d83ef Content-Type: text/plain; charset="UTF-8" Use std::vector instead of malloc'd pointer to get automatic freeing of memory. Result was verified by valgrind, which showed one less loss record. I think Jonathan is/was working on this transition but on a larger scale. --0000000000006f29de060b8d83ef-- --0000000000006f29e0060b8d83f1 Content-Type: application/octet-stream; name="0001-driver-Fix-memory-leak.patch" Content-Disposition: attachment; filename="0001-driver-Fix-memory-leak.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lpojm7td0 RnJvbSBjZjQ0NGE4YzUxNDY2MjlhYzg4M2RhNDZmNWY1MzAwY2Q5ZjNkNzVl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDb3N0YXMgQXJneXJp cyA8Y29zdGFzLmFyZ3lyaXNAZ21haWwuY29tPgpEYXRlOiBTYXQsIDIgRGVj IDIwMjMgMjA6NTI6MDcgKzAwMDAKU3ViamVjdDogW1BBVENIXSBkcml2ZXI6 IEZpeCBtZW1vcnkgbGVhay4KClVzZSBzdGQ6OnZlY3RvciBpbnN0ZWFkIG9m IG1hbGxvYydkIHBvaW50ZXIKdG8gZ2V0IGF1dG9tYXRpYyBmcmVlaW5nIG9m IG1lbW9yeS4KClJlc3VsdCB3YXMgdmVyaWZpZWQgYnkgdmFsZ3JpbmQsIHdo aWNoIHNob3dlZApvbmUgbGVzcyBsb3NzIHJlY29yZC4KClNpZ25lZC1vZmYt Ynk6IENvc3RhcyBBcmd5cmlzIDxjb3N0YXMuYXJneXJpc0BnbWFpbC5jb20+ Ci0tLQogZ2NjL2djYy5jYyB8IDcgKysrKy0tLQogMSBmaWxlIGNoYW5nZWQs IDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9nY2MvZ2NjLmNjIGIvZ2NjL2djYy5jYwppbmRleCA5ZjIxYWQ5NDUzZS4u NjNiZTQyNDdmMWQgMTAwNjQ0Ci0tLSBhL2djYy9nY2MuY2MKKysrIGIvZ2Nj L2djYy5jYwpAQCAtNDcsNiArNDcsNyBAQCBjb21waWxhdGlvbiBpcyBzcGVj aWZpZWQgYnkgYSBzdHJpbmcgY2FsbGVkIGEgInNwZWMiLiAgKi8KICNpbmNs dWRlICJvcHRzLWpvYnNlcnZlci5oIgogI2luY2x1ZGUgImNvbW1vbi9jb21t b24tdGFyZ2V0LmgiCiAjaW5jbHVkZSAiZ2NjLXVybGlmaWVyLmgiCisjaW5j bHVkZSA8dmVjdG9yPgogCiAjaWZuZGVmIE1BVEhfTElCUkFSWQogI2RlZmlu ZSBNQVRIX0xJQlJBUlkgIm0iCkBAIC05NTM0LDcgKzk1MzUsNyBAQCBzdHJ1 Y3QgbWRzd2l0Y2hzdHIKICAgaW50IGxlbjsKIH07CiAKLXN0YXRpYyBzdHJ1 Y3QgbWRzd2l0Y2hzdHIgKm1kc3dpdGNoZXM7CitzdGF0aWMgc3RkOjp2ZWN0 b3I8c3RydWN0IG1kc3dpdGNoc3RyPiBtZHN3aXRjaGVzOwogc3RhdGljIGlu dCBuX21kc3dpdGNoZXM7CiAKIC8qIENoZWNrIHdoZXRoZXIgYSBwYXJ0aWN1 bGFyIGFyZ3VtZW50IHdhcyB1c2VkLiAgVGhlIGZpcnN0IHRpbWUgd2UKQEAg LTk3NTMsNyArOTc1NCw3IEBAIHNldF9tdWx0aWxpYl9kaXIgKHZvaWQpCiAg ICAgewogICAgICAgaW50IGkgPSAwOwogCi0gICAgICBtZHN3aXRjaGVzID0g WE5FV1ZFQyAoc3RydWN0IG1kc3dpdGNoc3RyLCBuX21kc3dpdGNoZXMpOwor ICAgICAgbWRzd2l0Y2hlcy5yZXNlcnZlIChuX21kc3dpdGNoZXMpOwogICAg ICAgZm9yIChzdGFydCA9IG11bHRpbGliX2RlZmF1bHRzOyAqc3RhcnQgIT0g J1wwJzsgc3RhcnQgPSBlbmQgKyAxKQogCXsKIAkgIHdoaWxlICgqc3RhcnQg PT0gJyAnIHx8ICpzdGFydCA9PSAnXHQnKQpAQCAtMTEzNjYsNyArMTEzNjcs NyBAQCBkcml2ZXI6OmZpbmFsaXplICgpCiAgIGlucHV0X2Zyb21fcGlwZSA9 IDA7CiAgIHN1ZmZpeF9zdWJzdCA9IE5VTEw7CiAKLSAgbWRzd2l0Y2hlcyA9 IE5VTEw7CisgIG1kc3dpdGNoZXMuY2xlYXIgKCk7CiAgIG5fbWRzd2l0Y2hl cyA9IDA7CiAKICAgdXNlZF9hcmcuZmluYWxpemUgKCk7Ci0tIAoyLjMwLjIK Cg== --0000000000006f29e0060b8d83f1--