From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id CBB603858C54 for ; Wed, 7 Jun 2023 10:21:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CBB603858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5149c76f4dbso1208282a12.1 for ; Wed, 07 Jun 2023 03:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686133314; x=1688725314; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=Ekci06QLyF56zHcqtEmyP89GysvyB36ZSDBfhQIsxps=; b=TQcvrzbsrriD15y4SOTUj4w4kycd/yWYNz8lkzFO7ekgctzPMb+iBhhY9MlSlBpt7A FrFDtAltWBjWBRBE5FjMXCohTSE4rNzCo8VlKbNs01dToBmKTHohScFTJaviZ3Ky7mTQ 1+cPeBcpKOsM/5vqEExWhvXijNhM+pDv9pvHnNcqPnGrkEGZWrE0cpU+IKIQF33PPgqr Zy7RqIxQWJIrGu8K1cLqv+ROGr+kKI7wl3Y5/2e7WF/Ik7DV6XpXL0Qc5xXWCLNgM1ly lRCJ5RjXP7sI9kOKt4jF96jQKTFbK2sXe7kzhonNbQvzSdm1eQDV8yX52GI3vb/NRTyH r9tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686133314; x=1688725314; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ekci06QLyF56zHcqtEmyP89GysvyB36ZSDBfhQIsxps=; b=Z2rVXgpkjapzV8Gy749MDyFudzlZ+1FKADZoThLiLddRne/uziawjeo/GVpAhe78tr 9/hW89EyDT/kX1dk3QVmh6d+cmjCTpe06MEhl9scVClaTiULOCOfnJ5gCBGDlwGKjJ80 AYaAR6V/S/aE/jgQVD9G/hqdEsizcXmvrS7MTBhpVpFY462St9Us84icJaSi0WUkBiP8 T9CrS/0sog0e54yqw43jv5lVgR/IYJabFaEizYuVevuJmUrV0wGqCtSagGKEghThRB0Q CC8Fk+5dgI3V3tIXBPlCJ7Htwh5py5JdZz3d2sdLCq5Ip2AA5q6WPEd3Ri5C1Dg9HRzG gKiw== X-Gm-Message-State: AC+VfDzLoaEtft9KVzmrmZIJ6my7FwJmYlY99bvRHcVGNEJ7nuOHKX+I wUkjfWaW00FxHCTEusHNPjsoTmXtCXGzvJoucCIBjBAalAQ= X-Google-Smtp-Source: ACHHUZ4YDdOx6wYO77gWlvYFYRSeW6qG88kNXb1yKiRpgarITBg78EX0GakQQP0+9mg8sTzW+01DQOGZpFDfBmcFero= X-Received: by 2002:a05:6402:1383:b0:510:cda9:1eb7 with SMTP id b3-20020a056402138300b00510cda91eb7mr4135941edv.21.1686133314090; Wed, 07 Jun 2023 03:21:54 -0700 (PDT) MIME-Version: 1.0 From: Costas Argyris Date: Wed, 7 Jun 2023 11:21:42 +0100 Message-ID: Subject: [PATCH] libiberty: pex-unix.c: Make pex_unix_cleanup signature always match body. To: gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary="0000000000003b0cba05fd878199" X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000003b0cba05fd878199 Content-Type: multipart/alternative; boundary="0000000000003b0cad05fd878197" --0000000000003b0cad05fd878197 Content-Type: text/plain; charset="UTF-8" I saw this while working on something else: pex_unix_cleanup signature doesn't always match the body of the function in terms of ATTRIBUTE_UNUSED. If the conditional code in the body is compiled, then ATTRIBUTE_UNUSED isn't correct. This change makes it always match, thereby making it a bit cleaner IMO. Costas --0000000000003b0cad05fd878197-- --0000000000003b0cba05fd878199 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-libiberty-pex-unix.c-Make-pex_unix_cleanup-signature.patch" Content-Disposition: attachment; filename="0001-libiberty-pex-unix.c-Make-pex_unix_cleanup-signature.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_liljvs020 RnJvbSA0Yzg0YWZkNjMxYWQwOTAxMWIyMzc3OTA1OTllMWMzMjA4NTJmODJk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDb3N0YXMgQXJneXJp cyA8Y29zdGFzLmFyZ3lyaXNAZ21haWwuY29tPgpEYXRlOiBXZWQsIDcgSnVu IDIwMjMgMTA6MzQ6MTQgKzAxMDAKU3ViamVjdDogW1BBVENIXSBsaWJpYmVy dHk6IHBleC11bml4LmM6IE1ha2UgcGV4X3VuaXhfY2xlYW51cCBzaWduYXR1 cmUgYWx3YXlzCiBtYXRjaCBib2R5LgoKU2lnbmVkLW9mZi1ieTogQ29zdGFz IEFyZ3lyaXMgPGNvc3Rhcy5hcmd5cmlzQGdtYWlsLmNvbT4KLS0tCiBsaWJp YmVydHkvcGV4LXVuaXguYyB8IDEwICsrKysrKystLS0KIDEgZmlsZSBjaGFu Z2VkLCA3IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvbGliaWJlcnR5L3BleC11bml4LmMgYi9saWJpYmVydHkvcGV4LXVu aXguYwppbmRleCAzM2I1YmNlMzFjMi4uMTBmOGRkZDJmZWIgMTAwNjQ0Ci0t LSBhL2xpYmliZXJ0eS9wZXgtdW5peC5jCisrKyBiL2xpYmliZXJ0eS9wZXgt dW5peC5jCkBAIC04MTQsOSArODE0LDkgQEAgcGV4X3VuaXhfZmRvcGVudyAo c3RydWN0IHBleF9vYmogKm9iaiBBVFRSSUJVVEVfVU5VU0VELCBpbnQgZmQs CiB9CiAKIHN0YXRpYyB2b2lkCi1wZXhfdW5peF9jbGVhbnVwIChzdHJ1Y3Qg cGV4X29iaiAqb2JqIEFUVFJJQlVURV9VTlVTRUQpCi17CiAjaWYgIWRlZmlu ZWQgKEhBVkVfV0FJVDQpICYmICFkZWZpbmVkIChIQVZFX1dBSVRQSUQpCitw ZXhfdW5peF9jbGVhbnVwIChzdHJ1Y3QgcGV4X29iaiAqb2JqKQorewogICB3 aGlsZSAob2JqLT5zeXNkZXAgIT0gTlVMTCkKICAgICB7CiAgICAgICBzdHJ1 Y3Qgc3RhdHVzX2xpc3QgKnRoaXM7CkBAIC04MjcsNSArODI3LDkgQEAgcGV4 X3VuaXhfY2xlYW51cCAoc3RydWN0IHBleF9vYmogKm9iaiBBVFRSSUJVVEVf VU5VU0VEKQogICAgICAgZnJlZSAodGhpcyk7CiAgICAgICBvYmotPnN5c2Rl cCA9ICh2b2lkICopIG5leHQ7CiAgICAgfQotI2VuZGlmCiB9CisjZWxzZQor cGV4X3VuaXhfY2xlYW51cCAoc3RydWN0IHBleF9vYmogKm9iaiBBVFRSSUJV VEVfVU5VU0VEKQoreworfQorI2VuZGlmCi0tIAoyLjMwLjIKCg== --0000000000003b0cba05fd878199--