From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 4B3E23858CDB for ; Mon, 17 Apr 2023 08:29:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B3E23858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x636.google.com with SMTP id q23so52500819ejz.3 for ; Mon, 17 Apr 2023 01:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681720172; x=1684312172; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=ytOYG8wajAKW+4vNWP8Uxph0KAhunNTkoU4KoCk4KFI=; b=U+MRKJYNj0vXvsYQ8maF/R+LcIzf0qlElt7FtZNZQAXx+OLZawRvIjkOr6xv6AcV9g Bn8oBe2DEPNUd0ZDCw6jx+xbRLIZNkPWqBksgqNn9RYgeOKK1N7pPm5yijHozkDevwFh aFuhc79RPzfot7TGrydB3lhoNCHaQg5CdtXFFKIgIQS6rxFDAoq4ChtGnDuZOKErFRBA Cu/EiCa5AThAqL3cIDSlmTBQeFZSzv5D7afMpBN0KnVYrzUL0fNB6FzghWJk37N/JTEm G2pH1sP04E/PgOX+ABDJ0MDpD3eHNPCrh42PwVo2795hsUv/Qx2xwAAiG7muxxkQfdvN bc3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681720172; x=1684312172; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ytOYG8wajAKW+4vNWP8Uxph0KAhunNTkoU4KoCk4KFI=; b=ZSg30IXPlDeR4hcGWZggdvM2UaVhvjNlVxI9tLMR/VxaKgjXZdZTd3aN0xG3jOTyqD sLisHGPiz0PaC4GQhu7LdOBZ2s3A/+XsVMbxbADnFk+YdqHRUqEIt++y7ppWO6KKUuwL sWxSNc7kJ+5U2Blggwa/P3Y3oNxgNIWVrMOTvUo9sb/qn/JmH8urVvefNwki06AwKLgu 3TLXYIh9JW7KPcvSRmclpsvrhnqlMhHqEbFHGIQ0+f3wIkjbdtpWH5N2qA7aoP4slINk eRceFOw8Q6wffTiC4A7lPULKhP5PUXnUWWN3IVZ9pg+SB0NCZvfA3O59cnPAFYmrmsL1 qD9A== X-Gm-Message-State: AAQBX9e0MguY38q3Mhp/z9cHGU4R68+LlxNWBhFROlvbXBbSgGtL/Z+s 4inzCetD3b5FX4NnrOvPPu9/5Dy2Uvm+zEaYqDqG10kl6KknsA== X-Google-Smtp-Source: AKy350aVDyxKulULrNR2acTERy0z76vvRqUe6TAUu+AcO5f9pBZFrDXbUotrDnrT5DNd2iu3SZVtxlxtO6NyEqHE6Ok= X-Received: by 2002:a17:906:eb81:b0:93e:c1ab:ae67 with SMTP id mh1-20020a170906eb8100b0093ec1abae67mr3238960ejb.2.1681720172415; Mon, 17 Apr 2023 01:29:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Costas Argyris Date: Mon, 17 Apr 2023 09:29:21 +0100 Message-ID: Subject: Re: [PATCH] driver: Treat include path args the same way between cpp_unique_options and asm_options. [PR71850] To: gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="0000000000007d12c805f983fd85" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007d12c805f983fd85 Content-Type: text/plain; charset="UTF-8" Pinging list one last time about this. Proposed fix is to simply pass include paths to GNU AS through a @file, if a @file has been provided to gcc in the first place: https://gcc.gnu.org/bugzilla/attachment.cgi?id=54575&action=diff That is, simply change %{I*} to %@{I*} in asm_options. This mimics what is already happening for cpp_unique_options, and avoids overflowing the windows command line when many include paths are passed to gcc through @file. On Mon, 27 Mar 2023 at 11:11, Costas Argyris wrote: > Would it be possible to make it version-dependent, then? > > As in, if GNU assembler is greater or equal to the version that > supports @FILE, then pass @FILE to it, otherwise fall back to > the current behavior. > > I assume most people nowadays would have a version of > Binutils later than 2005, but if we could make it conditional on > the version then even those with earlier version wouldn't break, > they would just get the current behavior. > > On Mon, 27 Mar 2023 at 11:00, Xi Ruoyao wrote: > >> On Mon, 2023-03-27 at 10:36 +0100, Costas Argyris via Gcc-patches wrote: >> > [ping^3] >> > >> > This looks like it fixes the bug and also unifies the way include paths >> are >> > passed from the driver to the compiler and assembler (when a @file has >> > been passed to the driver in the first place). >> > >> > That is, when @file has been passed to the driver, put the include paths >> > in a temp @file and pass them to the assembler. Note this is already >> > happening for the compiler, so this patch merely extends this logic to >> the >> > assembler. >> > >> > Is there any reason not to go for it? >> >> It's not supported by all GNU assembler releases. For example, GCC >> installation doc says we require Binutils >= 2.13.1 for i?86-*-linux*. >> Binutils 2.13.1 was released in 2002, but @FILE support was added into >> Binutils in 2005. >> > > >> >> -- >> Xi Ruoyao >> School of Aerospace Science and Technology, Xidian University >> > --0000000000007d12c805f983fd85--