From: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
To: "Bin.Cheng" <amker.cheng@gmail.com>
Cc: Richard Earnshaw <rearnsha@arm.com>,
Bin Cheng <bin.cheng@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH ARM]memset inlining patch for arm
Date: Wed, 10 Sep 2014 08:53:00 -0000 [thread overview]
Message-ID: <CAJA7tRY0Of1kE7yoVmNaV1aNheSJmStC9rLW8PvE_4sq2WGx1A@mail.gmail.com> (raw)
In-Reply-To: <CAHFci2_1h4TwSKWjKsN08hbL3W7n9Qt9qi1ieDs2AEKxuq+DSg@mail.gmail.com>
On Wed, Sep 10, 2014 at 9:16 AM, Bin.Cheng <amker.cheng@gmail.com> wrote:
> On Tue, Sep 9, 2014 at 6:49 PM, Richard Earnshaw <rearnsha@arm.com> wrote:
>> On 04/09/14 07:08, Bin Cheng wrote:
>>> @@ -1872,7 +1892,9 @@ const struct tune_params arm_cortex_a53_tune =
>>> {true, true}, /* Prefer non short circuit. */
>>> &arm_default_vec_cost, /* Vectorizer costs. */
>>> false, /* Prefer Neon for 64-bits bitops. */
>>> - false, false /* Prefer 32-bit encodings. */
>>> + false, false, /* Prefer 32-bit encodings. */
>>> + false, /* Prefer Neon for stringops. */
>>> + 8 /* Maximum insns to inline memset. */
>>> };
>>>
>>> const struct tune_params arm_cortex_a57_tune =
>>> @@ -1889,7 +1911,9 @@ const struct tune_params arm_cortex_a57_tune =
>>> {true, true}, /* Prefer non short circuit. */
>>> &arm_default_vec_cost, /* Vectorizer costs. */
>>> false, /* Prefer Neon for 64-bits bitops. */
>>> - true, true /* Prefer 32-bit encodings. */
>>> + true, true, /* Prefer 32-bit encodings. */
>>> + false, /* Prefer Neon for stringops. */
>>> + 8 /* Maximum insns to inline memset. */
>>> };
>>
>> Why don't we use Neon for Cortex-(A53,A57)? We've used it for
>> Cortex-(A7,A8,A15).
> Hi Richard,
>
> Since changes in aarch64.md is needed, also the bug and patch are for
> arm only, I left this behind for aarch64. Another aarch64 patch
> should be worked for this in the near (?) future.
We should fix that up. Cortex-A57 and Cortex-A53 can run AArch32 code,
that's why you have that support in the ARM backend.
Ramana
>
> Thanks,
> bin
next prev parent reply other threads:[~2014-09-10 8:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 6:08 Bin Cheng
2014-09-04 15:21 ` Ramana Radhakrishnan
2014-09-05 19:33 ` Evandro Menezes
2014-09-10 8:12 ` Bin.Cheng
2014-09-09 10:49 ` Richard Earnshaw
2014-09-10 8:16 ` Bin.Cheng
2014-09-10 8:53 ` Ramana Radhakrishnan [this message]
2014-09-10 10:18 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJA7tRY0Of1kE7yoVmNaV1aNheSJmStC9rLW8PvE_4sq2WGx1A@mail.gmail.com \
--to=ramana.gcc@googlemail.com \
--cc=amker.cheng@gmail.com \
--cc=bin.cheng@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ramrad01@arm.com \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).