From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19525 invoked by alias); 17 Jun 2014 22:26:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19506 invoked by uid 89); 17 Jun 2014 22:26:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f49.google.com Received: from mail-qg0-f49.google.com (HELO mail-qg0-f49.google.com) (209.85.192.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 17 Jun 2014 22:26:21 +0000 Received: by mail-qg0-f49.google.com with SMTP id f51so9069qge.8 for ; Tue, 17 Jun 2014 15:26:18 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.224.50.205 with SMTP id a13mr40602255qag.19.1403043978776; Tue, 17 Jun 2014 15:26:18 -0700 (PDT) Received: by 10.224.168.144 with HTTP; Tue, 17 Jun 2014 15:26:18 -0700 (PDT) Reply-To: ramrad01@arm.com In-Reply-To: <5394488D.6060806@codesourcery.com> References: <5394488D.6060806@codesourcery.com> Date: Tue, 17 Jun 2014 22:26:00 -0000 Message-ID: Subject: Re: [PATCH, ARM] MI-thunk fix for TARGET_THUMB1_ONLY From: Ramana Radhakrishnan To: Chung-Lin Tang Cc: gcc-patches , Richard Earnshaw , Ramana Radhakrishnan , Julian Brown Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg01409.txt.bz2 On Sun, Jun 8, 2014 at 12:27 PM, Chung-Lin Tang wrote: > Hi Richard, Ramana, > > Attached is a small fix for resolving a g++.old-deja/g++.jason/thunk2.C > regression we found under a TARGET_THUMB1_ONLY multilib (-mthumb > -march=armv6-m to be exact). Basically under those conditions, the thunk > is in Thumb mode, so the subtraction should be 4 rather than 8. Yep, this is OK with a minor change to the comment to make it more explicit. >+ /* Output ".word .LTHUNKn-[37]-.LTHUNKPCn". */ s/37/3,7/ Ok with that change and if no regressions. OK for release branches unless the RM's object in 24 hours. It would be nice to see if we could rewrite the mi thunk code like other backends but that's the matter of a separate patch. Ramana > > Original patch was by Julian, with trivial adaptations for trunk by me. > We've been carrying this fix for a while by now. Okay for trunk? (and > stable branches?) > > Thanks, > Chung-Lin > > 2014-06-08 Julian Brown > Chung-Lin Tang > > * config/arm/arm.c (arm_output_mi_thunk): Fix offset for > TARGET_THUMB1_ONLY. Add comments.