From: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
To: Kugan <kugan.vivekanandarajah@linaro.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook
Date: Tue, 10 Jun 2014 14:32:00 -0000 [thread overview]
Message-ID: <CAJA7tRYTNdPxkyqeOfjoQWeKDnUNQ=969WSqpOyGuz+GnACaDQ@mail.gmail.com> (raw)
In-Reply-To: <53964262.5070404@linaro.org>
On Tue, Jun 10, 2014 at 12:25 AM, Kugan
<kugan.vivekanandarajah@linaro.org> wrote:
> On 30/05/14 18:35, Ramana Radhakrishnan wrote:
>>> + if (!TARGET_VFP)
>>> + return;
>>> +
>>> + /* Generate the equivalence of :
>>
>> s/equivalence/equivalent.
>>
>> Ok with that change and if no regressions.
>
> Hi Ramana,
>
> Sorry, I missed the thumb1 part. There are no mrc/mcr versions of these
> instructions in thumb1. So these should be conditional on not being
> ARM_THUMB1.
>
No, this has nothing to do with TARGET_THUMB1 - the real condition
should be TARGET_VFP && TARGET_HARD_FLOAT. These instructions only
work if TARGET_HARD_FLOAT is true. Thumb1 + VFP instructions is not
possible, similarly if generating code for -mfloat-abi=soft you don't
want these instructions being generated.
Ok if that works.
Ramana
> Is this OK. Regression tested with no new refression on qemu for
> arm-none-linux-gnueabi -march=armv7-a and on arm-none-linux-gnueabi
> --with-mode=thumb and -march=armv5t.
>
> Is this OK?
>
> Thanks,
> Kugan
>
> gcc/
>
> 2014-06-10 Kugan Vivekanandarajah <kuganv@linaro.org>
>
> * config/arm/arm.c (arm_atomic_assign_expand_fenv): call
> default_atomic_assign_expand_fenv for TARGET_THUMB1.
> (arm_init_builtins) : Initialize builtins __builtins_arm_set_fpscr and
> __builtins_arm_get_fpscr only when !TARGET_THUMB1.
> * config/arm/vfp.md (set_fpscr): Make pattern conditional on
> !TARGERT_THUMB1.
> (get_fpscr) : Likewise.
next prev parent reply other threads:[~2014-06-10 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 10:58 Kugan
2014-04-28 10:32 ` Ramana Radhakrishnan
2014-04-29 13:00 ` Kugan
2014-05-02 0:15 ` Joseph S. Myers
2014-05-02 9:05 ` Kugan
2014-05-11 23:47 ` Kugan
2014-05-26 8:01 ` Kugan
2014-05-30 8:35 ` Ramana Radhakrishnan
2014-06-09 23:25 ` Kugan
2014-06-10 14:32 ` Ramana Radhakrishnan [this message]
2014-06-23 12:32 ` Jay Foad
2014-07-12 8:11 Uros Bizjak
2014-07-12 22:40 ` Kugan
2014-07-22 16:32 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJA7tRYTNdPxkyqeOfjoQWeKDnUNQ=969WSqpOyGuz+GnACaDQ@mail.gmail.com' \
--to=ramana.gcc@googlemail.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kugan.vivekanandarajah@linaro.org \
--cc=ramrad01@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).