public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: "gcc Patches" <gcc-patches@gcc.gnu.org>, "Martin Liška" <mliska@suse.cz>
Subject: Re: [PATCH][PR91749][arm] FDPIC: Handle -mflip-thumb
Date: Mon, 16 Sep 2019 16:43:00 -0000	[thread overview]
Message-ID: <CAJA7tRY_33oVNW-cd+fT34wZdreCSnJvQ1AdOqM7CQdsHyXNqw@mail.gmail.com> (raw)
In-Reply-To: <CAKdteOZi-T-krNjfmCLtt2S61=KqDGLhYB3PJ61ozjtr4xgM3Q@mail.gmail.com>

On Mon, Sep 16, 2019 at 2:40 PM Christophe Lyon
<christophe.lyon@linaro.org> wrote:
>
> [Re-sending in plain text-mode, sorry for the duplicates]
>
> Hi,
>
> In PR91749, we have ICEs because -mflip-thumb switches to Thumb-1 (the
> default target cpu does not support Thumb-2).
>
> Although we already filter this in arm_configure_build_target, we
> forgot to handle cases when the mode is changed via attributes (either
> in the source code, or via -mflip-thumb).
>
> This patch adds the same error message when trying to apply the
> "thumb" attribute and the target does not support Thumb-2 (only if we
> are in FDPIC mode, of course).
>
> OK?

OK.

Ramana
>
> Thanks,
>
> Christophe

      reply	other threads:[~2019-09-16 16:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16 13:39 Christophe Lyon
2019-09-16 16:43 ` Ramana Radhakrishnan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJA7tRY_33oVNW-cd+fT34wZdreCSnJvQ1AdOqM7CQdsHyXNqw@mail.gmail.com \
    --to=ramana.gcc@googlemail.com \
    --cc=christophe.lyon@linaro.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).