From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-509062-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 5244 invoked by alias); 16 Sep 2019 16:43:13 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 5230 invoked by uid 89); 16 Sep 2019 16:43:13 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Google-Smtp-Source:APXvYqw, googlemail.com, googlemailcom, H*F:D*googlemail.com
X-HELO: mail-vs1-f45.google.com
Received: from mail-vs1-f45.google.com (HELO mail-vs1-f45.google.com) (209.85.217.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Sep 2019 16:43:07 +0000
Received: by mail-vs1-f45.google.com with SMTP id v10so82074vsc.7        for <gcc-patches@gcc.gnu.org>; Mon, 16 Sep 2019 09:43:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=googlemail.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=m5eM48JkIuMXoQEgfH05/S5+SRP1OwwXrmM36SjtWR8=;        b=E5nqF72s7gbZ6OG1ODv88+7ilfzvupWqMU/ANPVFjErJDigBOb3hMwOMqNxak6cNfQ         b3yMKcc56ONQms+FMt7rEafKgsw5uuIHj/WYKYTS5zIFPe3DexrPu16/5f9Y3upCD0yC         16Q4GCVIEB9p2N9s++H22x7j1PWXi5mCC2iTjQcqzdYmIopXtyWTTbAcfIe3LuAtHLkL         Zsd2eE6n+n8E7TJVIpAJlLsGq4IpcCLaKx5HyGCBwH9/BCUMLduQJK2iAACXOkG5jGHX         RugWj/W4HdQCj5JvRrkgre7YfamQ2Iw7oh7xOXPfvkmdcbmUtPBN65554qCqkcYqjbG/         19WA==
MIME-Version: 1.0
References: <CAKdteOZi-T-krNjfmCLtt2S61=KqDGLhYB3PJ61ozjtr4xgM3Q@mail.gmail.com>
In-Reply-To: <CAKdteOZi-T-krNjfmCLtt2S61=KqDGLhYB3PJ61ozjtr4xgM3Q@mail.gmail.com>
From: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
Date: Mon, 16 Sep 2019 16:43:00 -0000
Message-ID: <CAJA7tRY_33oVNW-cd+fT34wZdreCSnJvQ1AdOqM7CQdsHyXNqw@mail.gmail.com>
Subject: Re: [PATCH][PR91749][arm] FDPIC: Handle -mflip-thumb
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>, =?UTF-8?Q?Martin_Li=C5=A1ka?= <mliska@suse.cz>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2019-09/txt/msg00953.txt.bz2

On Mon, Sep 16, 2019 at 2:40 PM Christophe Lyon
<christophe.lyon@linaro.org> wrote:
>
> [Re-sending in plain text-mode, sorry for the duplicates]
>
> Hi,
>
> In PR91749, we have ICEs because -mflip-thumb switches to Thumb-1 (the
> default target cpu does not support Thumb-2).
>
> Although we already filter this in arm_configure_build_target, we
> forgot to handle cases when the mode is changed via attributes (either
> in the source code, or via -mflip-thumb).
>
> This patch adds the same error message when trying to apply the
> "thumb" attribute and the target does not support Thumb-2 (only if we
> are in FDPIC mode, of course).
>
> OK?

OK.

Ramana
>
> Thanks,
>
> Christophe