From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id A1D0D38582BB for ; Wed, 10 Aug 2022 20:31:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A1D0D38582BB Received: by mail-wr1-x430.google.com with SMTP id p10so19005165wru.8 for ; Wed, 10 Aug 2022 13:31:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=QHuWPvt9Hi3W5pH0Q8JYmiOe47MG9iL0zSKH3JLMKr4=; b=uQGR9w4xgTDV3UarxOgzLrG0hM0zbG4ly6epyWlKAJ0YE6KXWKKMMEPm7kDxpmukFV yP9kFR2nBZTeJgo2jeiF3uZ/tHSyPDZXWtZ+BrISryNdC3hspLaQ/0O9gJKeYysJ9LQg /czZzmvzz8Uhn/22zK3SY68AxOpeCKRRH2+GtCJ0BLKoLOSdzpqDHNExr0cFTNEvvw59 gjyPwjTf0u/GWOfvHZUHNHA6re5CHC6nbe38f2RcsDcnyQLbCGxn7fVHUbBiEQISYm4L AH1j5lIF+KFOGnXCIslU1j2LOykf/P1OJejZAK4XHg9+JEBFVTz5HvGXe0Zkr/x5NwAX +KJw== X-Gm-Message-State: ACgBeo1MmGDI55Fne7kAAagRnmJY2jv5mdpwMFSREOIMLyfrhSNwZ93l cPGJHi2hynp2VTEKJV8zL9O8qvczrKEGWOnac3w= X-Google-Smtp-Source: AA6agR4km31FvhOXow3gcKk9ZzJbpYI7UJjVycFHSxtDy9HjVNar+icanvuiy0FpgmSoMZHIC4/wB2Qhe0wEWe1/f0I= X-Received: by 2002:a5d:47c8:0:b0:221:61d0:c790 with SMTP id o8-20020a5d47c8000000b0022161d0c790mr16082069wrc.364.1660163470349; Wed, 10 Aug 2022 13:31:10 -0700 (PDT) MIME-Version: 1.0 References: <0edd0061-3b4e-7e9b-c2b5-517126252ffa@gmail.com> In-Reply-To: <0edd0061-3b4e-7e9b-c2b5-517126252ffa@gmail.com> From: Ramana Radhakrishnan Date: Wed, 10 Aug 2022 21:30:59 +0100 Message-ID: Subject: Re: [PATCH V2] arm: add -static-pie support To: Lance Fredrickson Cc: gcc-patches , Richard Earnshaw Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 20:31:13 -0000 Hi Lance, Thanks for your contribution - looks like your first one to GCC ? The patch looks good to me, though it should probably go through a full test suite run on arm-linux-gnueabihf and get a ChangeLog - see here for more https://gcc.gnu.org/contribute.html#patches. This is probably small enough to go under the 10 line rule but since you've used Signed-off-by in your patch, is that indicating you are contributing under DCO rules - https://gcc.gnu.org/contribute.html#legal ? regards Ramana On Thu, Aug 4, 2022 at 5:48 PM Lance Fredrickson via Gcc-patches wrote: > > Just a follow up trying to get some eyes on my static-pie patch > submission for arm. > Feedback welcome. > https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598610.html > > thanks, > Lance Fredrickson