From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-374559-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 22488 invoked by alias); 7 Aug 2014 08:01:00 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 22479 invoked by uid 89); 7 Aug 2014 08:00:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-qg0-f46.google.com
Received: from mail-qg0-f46.google.com (HELO mail-qg0-f46.google.com) (209.85.192.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 07 Aug 2014 08:00:58 +0000
Received: by mail-qg0-f46.google.com with SMTP id z60so3955146qgd.19        for <gcc-patches@gcc.gnu.org>; Thu, 07 Aug 2014 01:00:56 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.224.51.15 with SMTP id b15mr25282933qag.19.1407398456029; Thu, 07 Aug 2014 01:00:56 -0700 (PDT)
Received: by 10.224.138.79 with HTTP; Thu, 7 Aug 2014 01:00:55 -0700 (PDT)
Reply-To: ramrad01@arm.com
In-Reply-To: <53E32C99.9020202@samsung.com>
References: <53BE8EA4.7080803@arm.com>	<53BFA9A9.4090209@samsung.com>	<CAKdteOZCDuQS4+jH1wQH4U7g5Ew1BYmtDs65xpw3c2kJ9Ek2Pw@mail.gmail.com>	<53C64468.9000506@samsung.com>	<53C646BB.6020905@arm.com>	<53C7B202.3070401@samsung.com>	<53CFB98D.50005@samsung.com>	<53D8EB65.7040303@samsung.com>	<53E237CE.7050702@samsung.com>	<53E23832.4070707@arm.com>	<53E23F38.5020400@arm.com>	<53E32C99.9020202@samsung.com>
Date: Thu, 07 Aug 2014 08:01:00 -0000
Message-ID: <CAJA7tRZJCFk4cikpDPPT1y94=XYKzhgqMt4mGZxw13CXUooA5Q@mail.gmail.com>
Subject: Re: [PINGv3][PATCH] Fix for PR 61561
From: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
To: Marat Zakirov <m.zakirov@samsung.com>
Cc: Richard Earnshaw <rearnsha@arm.com>, Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>, 	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>, 	Christophe Lyon <christophe.lyon@linaro.org>, Slava Garbuzov <v.garbuzov@samsung.com>, 	Yury Gribov <y.gribov@samsung.com>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-08/txt/msg00768.txt.bz2

On Thu, Aug 7, 2014 at 8:36 AM, Marat Zakirov <m.zakirov@samsung.com> wrote:
> Thank you.
>
> $ svn commit
> Sending        gcc/ChangeLog
> Sending        gcc/config/arm/thumb1.md
> Sending        gcc/config/arm/thumb2.md
> Transmitting file data ...
> Committed revision 213695.
>
> P.S.
>
> Minor nit was reg. tested.

Another minor nit - please send the patch you committed to be archived
on the mailing list.

regards
Ramana

>
>
> On 08/06/2014 06:44 PM, Richard Earnshaw wrote:
>>
>> On 06/08/14 15:14, Ramana Radhakrishnan wrote:
>>>
>>>
>>> This is OK thanks.
>>>
>>>
>>> Ramana
>>>
>>
>> Hmm, minor nit.
>>
>>   (define_insn "*thumb1_movhi_insn"
>>     [(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l")
>> -       (match_operand:HI 1 "general_operand"       "l,m,l,*h,*r,I"))]
>> +       (match_operand:HI 1 "general_operand"       "lk,m,l,*h,*r,I"))]
>>
>> This would be better expressed as:
>>
>>     [(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,l*r,*h,l")
>>          (match_operand:HI 1 "general_operand"      "l,m,l,k*h,*r,I"))]
>>
>> that is, to use the 4th alternative.  That's because the use of SP in
>> these operations does not clobber the flags.
>>
>> Similarly for the movqi pattern.
>>
>> R.
>>
>>
>