public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
To: "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@cavium.com>
Cc: James Greenhalgh <james.greenhalgh@arm.com>,
		"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	"Pinski, Andrew" <Andrew.Pinski@cavium.com>,
		Marcus Shawcroft <marcus.shawcroft@arm.com>,
	Richard Earnshaw <Richard.Earnshaw@arm.com>,
		"nd@arm.com" <nd@arm.com>
Subject: Re: [PATCH][AArch64] Add crypto_pmull attribute
Date: Tue, 20 Jun 2017 09:41:00 -0000	[thread overview]
Message-ID: <CAJA7tRZLRiUfGbKgQJiJuvCzu7_1V-ReDSaMVNOwUpaa-K0aog@mail.gmail.com> (raw)
In-Reply-To: <CO2PR07MB2693E22FD168018005CDCFEF83C50@CO2PR07MB2693.namprd07.prod.outlook.com>

On Tue, Jun 20, 2017 at 10:26 AM, Hurugalawadi, Naveen
<Naveen.Hurugalawadi@cavium.com> wrote:
> Hi James,
>
> Thanks for the approval.
>
>>> From an AArch64 perspective, this is OK - but please wait for an ARM
>>> approval before you commit it.
>
> Can anyone from ARM comment on the patch so that it can be committed
> upstream if no issues.
>
> https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00504.html

Please update the ARM backend with the new attribute too ....

crypto.md:

(define_insn "crypto_vmullp64"
  [(set (match_operand:TI 0 "register_operand" "=w")
        (unspec:TI [(match_operand:DI 1 "register_operand" "w")
                    (match_operand:DI 2 "register_operand" "w")]
         UNSPEC_VMULLP64))]
  "TARGET_CRYPTO"
  "vmull.p64\\t%q0, %P1, %P2"
  [(set_attr "type" "neon_mul_d_long")]
)

Ok with that change and checking that you can build cc1 for arm-none-eabi .

regards
Ramana

>
> Thanks,
> Naveen
>

  reply	other threads:[~2017-06-20  9:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-06  5:11 Hurugalawadi, Naveen
2017-03-09 10:51 ` James Greenhalgh
2017-03-10  6:37   ` Hurugalawadi, Naveen
2017-04-25  7:10     ` [PING][PATCH][AArch64] " Hurugalawadi, Naveen
2017-05-11  4:52       ` [PING2][PATCH][AArch64] " Hurugalawadi, Naveen
2017-05-26  6:26         ` [PING 3][PATCH][AArch64] " Hurugalawadi, Naveen
2017-06-06 13:29     ` [PATCH][AArch64] " James Greenhalgh
2017-06-20  9:27       ` Hurugalawadi, Naveen
2017-06-20  9:41         ` Ramana Radhakrishnan [this message]
2017-06-21  5:55           ` Hurugalawadi, Naveen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJA7tRZLRiUfGbKgQJiJuvCzu7_1V-ReDSaMVNOwUpaa-K0aog@mail.gmail.com \
    --to=ramana.gcc@googlemail.com \
    --cc=Andrew.Pinski@cavium.com \
    --cc=Naveen.Hurugalawadi@cavium.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=james.greenhalgh@arm.com \
    --cc=marcus.shawcroft@arm.com \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).