From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62695 invoked by alias); 20 Jun 2017 09:41:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 62674 invoked by uid 89); 20 Jun 2017 09:41:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=201703, 2017-03 X-HELO: mail-pf0-f180.google.com Received: from mail-pf0-f180.google.com (HELO mail-pf0-f180.google.com) (209.85.192.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 09:41:39 +0000 Received: by mail-pf0-f180.google.com with SMTP id c73so6627238pfk.2 for ; Tue, 20 Jun 2017 02:41:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=w7dOJ3occjV0Xt8x8kf2rDxQ7qnPhl6hitDZVk8Q2JY=; b=rmntbht4JdkTSe/AQ16PpWmzQAng6MeNJnAJGA9phlX11tNNkhI2YIYsV3Lp38zGf0 +G3Ya1o7q6Jkq+Lh/NUx2K3VDFJGli/PXbDB7SfXB40PNcIUMCFha11BaNG8jxsX62o7 drXfCbWFb/b16AqRWo8c4EhChQvJ4MgXmJdcIbvWuHjnDji2DmVJ/j1cZoNle+p0MqoO RejfYKCIJ4BLQmEHyV7A6YSufNOsB/KM6nvvhtHRl4jkfOFxtOquxH5ybu9AJphM7gSF CSVU/DBBcZKVHW/b2nNloAt0CBNf4F246tpDLvWkfwnWG3NK7VlqR6cZFLlJ2+1+TKqP EZDA== X-Gm-Message-State: AKS2vOzRJyDW+8NmllNivP0fzYst4GCcQwWUnmj8XDxsRtxTecAnAy5L Uvt9iFd/HsQVQ1622sf37xnFuItSJQ== X-Received: by 10.99.44.19 with SMTP id s19mr30858031pgs.257.1497951697630; Tue, 20 Jun 2017 02:41:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.191.1 with HTTP; Tue, 20 Jun 2017 02:41:36 -0700 (PDT) In-Reply-To: References: <20170309105108.GA40548@arm.com> <20170606132913.GA3151@arm.com> From: Ramana Radhakrishnan Date: Tue, 20 Jun 2017 09:41:00 -0000 Message-ID: Subject: Re: [PATCH][AArch64] Add crypto_pmull attribute To: "Hurugalawadi, Naveen" Cc: James Greenhalgh , "gcc-patches@gcc.gnu.org" , "Pinski, Andrew" , Marcus Shawcroft , Richard Earnshaw , "nd@arm.com" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01418.txt.bz2 On Tue, Jun 20, 2017 at 10:26 AM, Hurugalawadi, Naveen wrote: > Hi James, > > Thanks for the approval. > >>> From an AArch64 perspective, this is OK - but please wait for an ARM >>> approval before you commit it. > > Can anyone from ARM comment on the patch so that it can be committed > upstream if no issues. > > https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00504.html Please update the ARM backend with the new attribute too .... crypto.md: (define_insn "crypto_vmullp64" [(set (match_operand:TI 0 "register_operand" "=w") (unspec:TI [(match_operand:DI 1 "register_operand" "w") (match_operand:DI 2 "register_operand" "w")] UNSPEC_VMULLP64))] "TARGET_CRYPTO" "vmull.p64\\t%q0, %P1, %P2" [(set_attr "type" "neon_mul_d_long")] ) Ok with that change and checking that you can build cc1 for arm-none-eabi . regards Ramana > > Thanks, > Naveen >