From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6253 invoked by alias); 15 Dec 2015 21:08:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6241 invoked by uid 89); 15 Dec 2015 21:08:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_50,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wm0-f43.google.com Received: from mail-wm0-f43.google.com (HELO mail-wm0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 15 Dec 2015 21:08:08 +0000 Received: by mail-wm0-f43.google.com with SMTP id n186so44340006wmn.0 for ; Tue, 15 Dec 2015 13:08:08 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.194.91.206 with SMTP id cg14mr2279332wjb.30.1450213685805; Tue, 15 Dec 2015 13:08:05 -0800 (PST) Received: by 10.194.137.208 with HTTP; Tue, 15 Dec 2015 13:08:05 -0800 (PST) In-Reply-To: <567039B5.3010504@foss.arm.com> References: <56572B79.9000406@foss.arm.com> <56572CEA.6020805@foss.arm.com> <5665AECD.8050106@foss.arm.com> <56668AA1.5080103@st.com> <567039B5.3010504@foss.arm.com> Date: Tue, 15 Dec 2015 21:08:00 -0000 Message-ID: Subject: Re: [PATCH 4/7][ARM] Add ACLE feature macro for ARMv8.1 instructions. From: Ramana Radhakrishnan To: Matthew Wahab Cc: Ramana Radhakrishnan , Christian Bruel , gcc-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg01521.txt.bz2 On Tue, Dec 15, 2015 at 4:03 PM, Matthew Wahab wrote: > On 10/12/15 10:45, Ramana Radhakrishnan wrote: >> >> On Tue, Dec 8, 2015 at 7:45 AM, Christian Bruel >> wrote: >>> >>> Hi Matthew, >>>> >>>> >>>> On 26/11/15 16:01, Matthew Wahab wrote: >>>>> >>>>> >>>>> Hello, >>>>> >>>>> This patch adds the feature macro __ARM_FEATURE_QRDMX to indicate the >>>>> presence of the ARMv8.1 instructions vqrdmlah and vqrdmlsh. It is >>>>> defined when the instructions are available, as it is when >>>>> -march=armv8.1-a is enabled with suitable fpu options. >>>>> >>>>> gcc/ >>>>> 2015-11-26 Matthew Wahab >>>>> >>>>> * config/arm/arm-c.c (arm_cpu_builtins): Define >>>>> __ARM_FEATURE_QRDMX. >>>>> >>>> >>> >>> + if (TARGET_NEON_RDMA) >>> + builtin_define ("__ARM_FEATURE_QRDMX"); >>> + >>> >>> Since it depends on TARGET_NEON, could you please use >>> >>> def_or_undef_macro (pfile, "__ARM_FEATURE_QRDMX", TARGET_NEON_RDMA); >>> >>> instead ? >> >> >> I think that's what it should be - >> >> OK with that fixed. > > > Attached an updated patch using the def_or_undef macro. It also removes some > trailing whitespace in that part of the code. > > Still ok? Yep, OK. regards Ramana > Matthew > > gcc/ > 2015-12-14 Matthew Wahab > > * config/arm/arm-c.c (arm_cpu_builtins): Define > __ARM_FEATURE_QRDMX. Clean up some trailing whitespace. > >