From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 594C93852211 for ; Thu, 17 Nov 2022 21:02:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 594C93852211 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=googlemail.com Received: by mail-wr1-x435.google.com with SMTP id g12so5856529wrs.10 for ; Thu, 17 Nov 2022 13:02:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=piRWZ3/8+YFuGYgje5oHgw+JuhQP5DjuoVXl2b7g/HA=; b=UtrRRudfgGfzUbf+t+5PQ+kUeGrGhN0AQYAbEwduFvi1OfIueaw4MJgSJNwK4aj4Ik ZQD93xySLeXIJQBycGI3C09c0oq7891xy6iV6For4hOSLKCdOQgQu0bFPhmmnvGGGK6J cu9kuoXVg8xncsB+xKGaXMDcyxBH4JzU+3kuK/6/ZuedcVNlzUxC7+W5GgLMVVUNcvde YRu7QqyZCN2t1mVu9Q5kllM2j6m43YFOEdb0ECLBcvYzYuSX/9Kdab8YHRnajCIZJUtE dRc5fSO2qhQIKpgSKmMQPw3kwEy3I9eiXbnI7emYHcpTaYZoRMTvGj47ihK6LtSlJLf8 u9Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=piRWZ3/8+YFuGYgje5oHgw+JuhQP5DjuoVXl2b7g/HA=; b=MIUbeeFlpfnAsHccGfRTRD1XZBP2W26+IZJ8H9APAs5gLannnzSZJcovTUqBSsI3+s YEeeHPSYg+TU+es5k+LkEBjjju0PYC9JhGS1x2C2dxY0n9Re0fRhZ6KmmClw9fEKJo9C ujM0iBpDmRFg2NqYfmoxlTuQNL03zEVP6adtYTRjU1daadus76W9oQNFeMGM0411nWMW tPMkhEockz0pHpgy7wMSQIpTxL2bIAPIVyeclSVQDCRTObLXliwCDbD6Uz5ABxAlfIkG c0iEZHddELc658V9xXSGNBQc2aP1z9xgvma4JbdFNe7oJFTeP6kFCCrbvMbV/0Ow6osg txZQ== X-Gm-Message-State: ANoB5pm9KkD/bPddcV+5c0186lHlIypGg27IK8WB5leNqguAUTv3lIE6 ZZN/yNjFaYoaUkiPFBrWI7SSPk1potuP8cZAOiM= X-Google-Smtp-Source: AA0mqf49evP+n+OIWdGu8XVLyfBnVCUgdG0Ohb4HrDERHh8gcfrGePjMTXpQMqVUOZe1c1h2DyXxW0oParkouCLcI3k= X-Received: by 2002:a5d:4d4c:0:b0:236:55eb:a25a with SMTP id a12-20020a5d4d4c000000b0023655eba25amr2619984wru.55.1668718947211; Thu, 17 Nov 2022 13:02:27 -0800 (PST) MIME-Version: 1.0 References: <3519176.R56niFO833@fomalhaut> In-Reply-To: <3519176.R56niFO833@fomalhaut> From: Ramana Radhakrishnan Date: Thu, 17 Nov 2022 21:02:16 +0000 Message-ID: Subject: Re: [PATCH] ARM: Make ARMv8-M attribute cmse_nonsecure_call work in Ada To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 24, 2022 at 9:55 AM Eric Botcazou via Gcc-patches wrote: > > Hi, > > until most other machine attributes, this one does not work in Ada because, > while it applies to pointer-to-function types, it is explicitly marked as > requiring declarations in the implementation. > > Now, in Ada, machine attributes are specified like this: > > type Non_Secure is access procedure; > pragma Machine_Attribute (Non_Secure, "cmse_nonsecure_call"); > > i.e. not attached to the declaration of Non_Secure (testcase attached). > > So the attached patch extends the support to Ada by also accepting > pointer-to-function types in the handler. > > Tested on arm-eabi, OK for the mainline? > Ok if no regressions, perhaps the test needs to be in the ada test suite ? regards Ramana > > 2022-10-24 Eric Botcazou > > * config/arm/arm.cc (arm_attribute_table) : Change > decl_required field to false. > (arm_handle_cmse_nonsecure_call): Deal with a TYPE node. > > > -- > Eric Botcazou