public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
To: Matthew Wahab <matthew.wahab@foss.arm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 5/5][ARM] Move initializer into arm-cores.def and arm-arches.def.
Date: Tue, 18 Aug 2015 07:38:00 -0000	[thread overview]
Message-ID: <CAJA7tRZvGZFADwnu8aQfFgJE+e3y=8+gegotx5nwL4GgWC0O9A@mail.gmail.com> (raw)
In-Reply-To: <55C89242.2040100@foss.arm.com>

On Mon, Aug 10, 2015 at 1:00 PM, Matthew Wahab
<matthew.wahab@foss.arm.com> wrote:
> The ARM backend uses an unsigned long to record CPU feature flags and
> there are currently 30 bits in use. This series of patches replaces the
> single unsigned long with a representation based on an array of values.
>
> This patch updates the entries in the arm-core.def and arm-arches.def
> files to for the new arm_feature_set representation, moving the
> initializers from a macro expansion and making them explicit in the file
> entries.
>
> Tested the series for arm-none-linux-gnueabihf with native bootstrap and
> make check.
>
> gcc/
> 2015-08-10  Matthew Wahab  <matthew.wahab@arm.com>
>
>         * config/arm/arm-arches.def: Replace single value flags with
>         initializer built from ARM_FSET_MAKE_CPU1.
>         * config/arm/arm-cores.def: Likewise.
>         * config/arm/arm.c: (all_cores): Remove ARM_FSET_MAKE_CPU1
>         derivation from the ARM_CORE macro definition, use the given value
>         instead.
>         (all_architectures): Remove ARM_FSET_MAKE_CPU1 derivation from the
>         ARM_ARCH macro definition, use the given value instead.
>
>

Please update the comment at the top level of arm-arches.def and
arm-cores.def to reflect this change with respect to "FLAGS".

Ok with that change.


Ramana

  reply	other threads:[~2015-08-18  7:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 11:55 [PATCH 1/5][ARM] Make room for more CPU feature flags Matthew Wahab
2015-08-10 11:57 ` [PATCH 2/5][ARM] Add feature set definitions Matthew Wahab
2015-08-10 15:02   ` Ramana Radhakrishnan
2015-08-10 11:58 ` [PATCH 3/5][ARM] Use new feature set representation Matthew Wahab
2015-08-18  7:27   ` Ramana Radhakrishnan
2015-08-10 11:59 ` [PATCH 4/5][ARM] Use features sets for builtins Matthew Wahab
2015-08-18  7:31   ` Ramana Radhakrishnan
2015-08-10 12:00 ` [PATCH 5/5][ARM] Move initializer into arm-cores.def and arm-arches.def Matthew Wahab
2015-08-18  7:38   ` Ramana Radhakrishnan [this message]
2015-08-10 15:11 ` [PATCH 1/5][ARM] Make room for more CPU feature flags Ramana Radhakrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJA7tRZvGZFADwnu8aQfFgJE+e3y=8+gegotx5nwL4GgWC0O9A@mail.gmail.com' \
    --to=ramana.gcc@googlemail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=matthew.wahab@foss.arm.com \
    --cc=ramrad01@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).