From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2309 invoked by alias); 31 Oct 2014 17:41:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2299 invoked by uid 89); 31 Oct 2014 17:41:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f53.google.com Received: from mail-qg0-f53.google.com (HELO mail-qg0-f53.google.com) (209.85.192.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 31 Oct 2014 17:41:36 +0000 Received: by mail-qg0-f53.google.com with SMTP id z107so6010730qgd.12 for ; Fri, 31 Oct 2014 10:41:34 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.140.25.167 with SMTP id 36mr36785338qgt.56.1414777294030; Fri, 31 Oct 2014 10:41:34 -0700 (PDT) Received: by 10.140.18.133 with HTTP; Fri, 31 Oct 2014 10:41:33 -0700 (PDT) Reply-To: ramrad01@arm.com In-Reply-To: <54482653.5060805@linaro.org> References: <543633BD.9030004@linaro.org> <54363F8A.8020501@arm.com> <54482653.5060805@linaro.org> Date: Fri, 31 Oct 2014 18:44:00 -0000 Message-ID: Subject: Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes From: Ramana Radhakrishnan To: Michael Collison Cc: Tejas Belagod , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg03356.txt.bz2 On Wed, Oct 22, 2014 at 10:49 PM, Michael Collison wrote: > > Patch that removes extraneous comment attached. > > The CLZ_DEFINED_VALUE_AT_ZERO macro is hard coded to return 32. For the > vector intrinsic vclz this is incorrect and should return the value vclz_{s,u}8 ... > eight. The CTZ_DEFINED_VALUE_AT_ZERO has the same issue. The patch is ok . Sorry about the delay in reviewing this. Ramana > > Tested on arm-linux-gnueabihf, arm-linux-gnueabi. > > 2014-10-08 Michael Collison > > * config/arm/arm.h (CLZ_DEFINED_VALUE_AT_ZERO) : Update > to support vector modes > (CTZ_DEFINED_VALUE_AT_ZERO): Ditto > > On 10/09/2014 12:55 AM, Tejas Belagod wrote: >> >> On 09/10/14 08:05, Michael Collison wrote: >>> >>> >>> The CLZ_DEFINED_VALUE_AT_ZERO macro is harded to return 32. For the >>> vector intrinsic vclz this is incorrect and should return the value >>> eight. The CTZ_DEFINED_VALUE_AT_ZERO has the same issue. >>> >>> Tested on arm-linux-gnueabihf, arm-linux-gnueabi. >>> >>> 2014-10-08 Michael Collison >>> >>> * config/arm/arm.h (CLZ_DEFINED_VALUE_AT_ZERO) : Update >>> to support vector modes >>> (CTZ_DEFINED_VALUE_AT_ZERO): Ditto >>> >> >> Update comment? >> >> /* The arm5 clz instruction returns 32. */ >> >> >> Thanks, >> Tejas. >> > > -- > Michael Collison > Linaro Toolchain Working Group > michael.collison@linaro.org >