From: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Earnshaw <richard.earnshaw@arm.com>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
Kyrylo Tkachov <kyrylo.tkachov@arm.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] arm: Fix ICE on glibc compilation after my DIVMOD optimization [PR97322]
Date: Thu, 8 Oct 2020 10:23:44 +0100 [thread overview]
Message-ID: <CAJA7tRa0BHuopOi2h5tUpJX56tT2qndBUYojt=na-9-8Y-FOag@mail.gmail.com> (raw)
In-Reply-To: <20201008091953.GP2176@tucnak>
On Thu, Oct 8, 2020 at 10:22 AM Jakub Jelinek via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi!
>
> The arm target hook for divmod wasn't prepared to handle constants passed to
> the function.
>
> Fixed thusly, bootstrapped/regtested on armv7hl-linux-gnueabi, ok for trunk?
>
> 2020-10-08 Jakub Jelinek <jakub@redhat.com>
>
> PR target/97322
> * config/arm/arm.c (arm_expand_divmod_libfunc): Pass mode instead of
> GET_MODE (op0) or GET_MODE (op1) to emit_library_call_value.
>
> * gcc.dg/pr97322.c: New test.
Ok.
Ramana
>
> --- gcc/config/arm/arm.c.jj 2020-10-07 10:47:46.892985596 +0200
> +++ gcc/config/arm/arm.c 2020-10-07 20:19:25.524367665 +0200
> @@ -33275,9 +33275,7 @@ arm_expand_divmod_libfunc (rtx libfunc,
> = smallest_int_mode_for_size (2 * GET_MODE_BITSIZE (mode));
>
> rtx libval = emit_library_call_value (libfunc, NULL_RTX, LCT_CONST,
> - libval_mode,
> - op0, GET_MODE (op0),
> - op1, GET_MODE (op1));
> + libval_mode, op0, mode, op1, mode);
>
> rtx quotient = simplify_gen_subreg (mode, libval, libval_mode, 0);
> rtx remainder = simplify_gen_subreg (mode, libval, libval_mode,
> --- gcc/testsuite/gcc.dg/pr97322.c.jj 2020-10-07 20:19:54.071961807 +0200
> +++ gcc/testsuite/gcc.dg/pr97322.c 2020-10-07 20:19:16.897490309 +0200
> @@ -0,0 +1,17 @@
> +/* PR target/97322 */
> +/* { dg-do compile } */
> +/* { dg-options "-O2" } */
> +
> +void
> +foo (unsigned long long x, unsigned long long *y)
> +{
> + y[0] = x / 10;
> + y[1] = x % 10;
> +}
> +
> +void
> +bar (unsigned int x, unsigned int *y)
> +{
> + y[0] = x / 10;
> + y[1] = x % 10;
> +}
>
> Jakub
>
prev parent reply other threads:[~2020-10-08 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 9:19 Jakub Jelinek
2020-10-08 9:23 ` Ramana Radhakrishnan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJA7tRa0BHuopOi2h5tUpJX56tT2qndBUYojt=na-9-8Y-FOag@mail.gmail.com' \
--to=ramana.gcc@googlemail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kyrylo.tkachov@arm.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).