From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16792 invoked by alias); 18 Aug 2015 07:27:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16753 invoked by uid 89); 18 Aug 2015 07:27:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f44.google.com Received: from mail-oi0-f44.google.com (HELO mail-oi0-f44.google.com) (209.85.218.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 18 Aug 2015 07:27:54 +0000 Received: by oio137 with SMTP id 137so95792616oio.0 for ; Tue, 18 Aug 2015 00:27:53 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.85.138 with SMTP id j132mr4447394oib.101.1439882873016; Tue, 18 Aug 2015 00:27:53 -0700 (PDT) Received: by 10.202.209.3 with HTTP; Tue, 18 Aug 2015 00:27:52 -0700 (PDT) Reply-To: ramrad01@arm.com In-Reply-To: <55C89202.4030602@foss.arm.com> References: <55C89141.8050304@foss.arm.com> <55C89202.4030602@foss.arm.com> Date: Tue, 18 Aug 2015 07:31:00 -0000 Message-ID: Subject: Re: [PATCH 4/5][ARM] Use features sets for builtins. From: Ramana Radhakrishnan To: Matthew Wahab Cc: gcc-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00950.txt.bz2 On Mon, Aug 10, 2015 at 12:58 PM, Matthew Wahab wrote: > The ARM backend uses an unsigned long to record CPU feature flags and > there are currently 31 bits in use. This series of patches replaces the > single unsigned long with a representation based on an array of values. > > This patch updates the feature flags usage in the builtins description > to be able use make of all representable flags. > > Tested the series for arm-none-linux-gnueabihf with native bootstrap and > make check. > > gcc/ > 2015-08-10 Matthew Wahab > > * config/arm/arm-builtins.c (def_mbuiltin): Test all flags in a > feature set. > (struct builtin_description): Replace field mask with field > features. > (IWMMXT_BUILTIN): Use ARM_FSET macros for feature flags. > (IWMMXT2_BUILTIN): Likewise. > (IWMMXT2_BUILTIN2): Likewise. > (FP_BUILTIN): Likewise. > (CRC32_BUILTIN): Likewise. > (CRYPTO_BUILTIN): Likewise. > (iwmmx_mbuiltin): Likewise. > (iwmmx2_mbuiltin): Likewise. > (arm_init_iwmmxt_builtins): Likewise. Also, update for change to > struct builtin_description. > OK - please watch out for any fallout in the next couple of days with any auto-testers. Ramana