From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16172 invoked by alias); 25 Jul 2017 12:52:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 15504 invoked by uid 89); 25 Jul 2017 12:52:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1781 X-HELO: mail-pf0-f196.google.com Received: from mail-pf0-f196.google.com (HELO mail-pf0-f196.google.com) (209.85.192.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Jul 2017 12:52:16 +0000 Received: by mail-pf0-f196.google.com with SMTP id 1so4771502pfi.3 for ; Tue, 25 Jul 2017 05:52:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1gwosrve+PdXC+Rr8KSsLWIp/zgzTUduFPSXGXqfXBg=; b=q6Qxpa/jXIQMXkwKw5WoRzRsuRxhHGCNgHVKru2QXL9G3T7yvwZHUtSMEsRrxEZONh rNoI7MfSchZBZT0l4u0ukvy+Cf+Eu50GMrRvvFvBOFDomUeNufh6KryU8og/T4ciIfbg XtBleFRf0qnrhcXCgHFe+u0l76GTztNXClPT9FikqKSPNJZLmmXfSlh4cLWIh/DQE71R 2+1v0jRP7Wk3tXJeA3hVJdyrxjpZVWTJ1l3iXu1m3nQnMl0Iu7wUVOOsmIQmdmmRDLej zXYGCm/5YFb+I/MOAERDNR0keShdYlaoFWzYd5LIYqvHqAL8s+5zwng//+R+m53eL/jI 3IVA== X-Gm-Message-State: AIVw111oNwJt+0RdJbMagGSQC3/ietCVL0JaXn3mq818NVnsOMqKRGOI s3hznkyf3GflHGUV/BbPH1VbeVrllg== X-Received: by 10.98.155.90 with SMTP id r87mr19490738pfd.56.1500987134970; Tue, 25 Jul 2017 05:52:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.189.79 with HTTP; Tue, 25 Jul 2017 05:52:14 -0700 (PDT) In-Reply-To: References: <20170724170520.GC14816@arm.com> From: Ramana Radhakrishnan Date: Tue, 25 Jul 2017 12:52:00 -0000 Message-ID: Subject: Re: [COMMITED][AArch64] Fix PR79041 To: Wilco Dijkstra Cc: James Greenhalgh , GCC Patches , nd , Yvan Roux Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg01548.txt.bz2 On Tue, Jul 25, 2017 at 1:13 PM, Wilco Dijkstra wrote: > James Greenhalgh wrote: >> >> OK. Either like this, or with the conditions swapped around as Yvan >> suggested to make backporting easier. > > I swapped the conditions around, not sure whether it helps... > Also I needed an additional scan-assembler, this was committed to > trunk and GCC7: BZ suggests that this affects GCC 6 but GCC 7 is fixed ? Should there be a backport to GCC 6 as well ? Can you please keep BZ up to date please ? Ramana > > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index d7fab3775c06477365217e357b5754026d09752b..7713d543af788d47dcdf8ea89482a2d4f66a1344 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -10181,7 +10181,7 @@ aarch64_classify_symbol (rtx x, rtx offset) > /* This is alright even in PIC code as the constant > pool reference is always PC relative and within > the same translation unit. */ > - if (CONSTANT_POOL_ADDRESS_P (x)) > + if (!aarch64_pcrelative_literal_loads && CONSTANT_POOL_ADDRESS_P (x)) > return SYMBOL_SMALL_ABSOLUTE; > else > return SYMBOL_FORCE_TO_MEM; > diff --git a/gcc/testsuite/gcc.target/aarch64/pr79041-2.c b/gcc/testsuite/gcc.target/aarch64/pr79041-2.c > new file mode 100644 > index 0000000000000000000000000000000000000000..cd34fbab85a92d00cba7091d4146deaaf3a862a9 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/aarch64/pr79041-2.c > @@ -0,0 +1,11 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -mcmodel=large -mpc-relative-literal-loads" } */ > + > +__int128 > +t (void) > +{ > + return (__int128)1 << 80; > +} > + > +/* { dg-final { scan-assembler "adr" } } */ > +/* { dg-final { scan-assembler-not "adrp" } } */