From: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Kyrylo Tkachov <kyrylo.tkachov@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Richard Sandiford <Richard.Sandiford@arm.com>
Subject: [Patch Arm] Add neon_fcmla and neon_fcadd as neon_type instructions.
Date: Sun, 20 Nov 2022 22:50:06 +0000 [thread overview]
Message-ID: <CAJA7tRaUaDNB_rGUUPBOWQHZVCFN8uoiCVEWcoAX3q9MvyyPWw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 407 bytes --]
[AArch64 folks CC'd fyi as this is common between both backends.]
Hi,
The design in the backend used to be that advanced simd types are
generally added to is_neon_type in the backend. It appears that
neon_fcmla and neon_fcadd aren't added in as neon_type instructions.
Applying this to the tree later this week after having built armhf and
a bootstrap and test run on aarch64-linux-gnu.
Thanks,
Ramana
[-- Attachment #2: p1.txt --]
[-- Type: text/plain, Size: 1399 bytes --]
commit 7dd15fae0ac1455f5818a1fc0078e35d85e1e250
Author: Ramana Radhakrishnan <ramana.gcc@gmail.com>
Date: Wed Nov 16 10:32:04 2022 +0000
[Patch Arm] Add neon_fcadd and neon_fcmla to is_neon_type.
Appears to have been an oversight.
gcc/
* config/arm/types.md: Update comment.
(is_neon_type): Add neon_fcmla, neon_fcadd.
Signed-off-by: Ramana Radhakrishnan <ramana.gcc@gmail.com>
diff --git a/gcc/config/arm/types.md b/gcc/config/arm/types.md
index 7d0504bdd94..d0d9997efd2 100644
--- a/gcc/config/arm/types.md
+++ b/gcc/config/arm/types.md
@@ -248,7 +248,8 @@ (define_attr "autodetect_type"
; wmmx_wunpckil
; wmmx_wxor
;
-; The classification below is for NEON instructions.
+; The classification below is for NEON instructions. If a new neon type is
+; added, please ensure this is added to the is_neon_type attribute below too.
;
; neon_add
; neon_add_q
@@ -1281,6 +1282,7 @@ (define_attr "is_neon_type" "yes,no"
neon_fp_mla_d_q, neon_fp_mla_d_scalar_q, neon_fp_sqrt_s,\
neon_fp_sqrt_s_q, neon_fp_sqrt_d, neon_fp_sqrt_d_q,\
neon_fp_div_s, neon_fp_div_s_q, neon_fp_div_d, neon_fp_div_d_q, crypto_aese,\
+ neon_fcadd, neon_fcmla, \
crypto_aesmc, crypto_sha1_xor, crypto_sha1_fast, crypto_sha1_slow,\
crypto_sha256_fast, crypto_sha256_slow")
(const_string "yes")
reply other threads:[~2022-11-20 22:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJA7tRaUaDNB_rGUUPBOWQHZVCFN8uoiCVEWcoAX3q9MvyyPWw@mail.gmail.com \
--to=ramana.gcc@googlemail.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Richard.Sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).