From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14246 invoked by alias); 6 Mar 2013 23:05:00 -0000 Received: (qmail 14238 invoked by uid 22791); 6 Mar 2013 23:04:59 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-ie0-f175.google.com (HELO mail-ie0-f175.google.com) (209.85.223.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Mar 2013 23:04:54 +0000 Received: by mail-ie0-f175.google.com with SMTP id c12so10067811ieb.6 for ; Wed, 06 Mar 2013 15:04:54 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.50.157.138 with SMTP id wm10mr13023358igb.103.1362611094419; Wed, 06 Mar 2013 15:04:54 -0800 (PST) Received: by 10.231.125.10 with HTTP; Wed, 6 Mar 2013 15:04:54 -0800 (PST) Reply-To: ramrad01@arm.com In-Reply-To: <20130306090736.GQ12913@tucnak.redhat.com> References: <20130306090736.GQ12913@tucnak.redhat.com> Date: Wed, 06 Mar 2013 23:05:00 -0000 Message-ID: Subject: Re: [PATCH] Fix install-plugin on arm and aarch64 From: Ramana Radhakrishnan To: Jakub Jelinek Cc: Marcus Shawcroft , Richard Earnshaw , Ramana Radhakrishnan , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-03/txt/msg00275.txt.bz2 On Wed, Mar 6, 2013 at 9:07 AM, Jakub Jelinek wrote: > Hi! > > https://bugzilla.redhat.com/show_bug.cgi?id=910926 > reports that plugins aren't usable on arm, because arm-cores.def isn't > installed into the plugins directory. arm-cores.def can't be included in > tm_file list, because we don't want to include it directly, nor in > HeaderInclude in arm.opt (that breaks the build). rs6000 has similar issue > with its rs6000-builtin.def, and solves this by adding content to TM_H > in Makefile fragment. > > Thus, the following patch does the same for arm (and apparently aarch64 has > the same issue). Ok for trunk? > > 2013-03-06 Jakub Jelinek > > * config/aarch64/t-aarch64 (TM_H, OPTIONS_H_EXTRA): Add > aarch64-cores.def. > * config/arm/t-arm (TM_H, OPTIONS_H_EXTRA): Add arm-cores.def. Ok. Thanks, Ramana > > --- gcc/config/aarch64/t-aarch64.jj 2013-02-24 19:44:07.000000000 +0100 > +++ gcc/config/aarch64/t-aarch64 2013-03-06 09:42:31.568042231 +0100 > @@ -18,6 +18,9 @@ > # along with GCC; see the file COPYING3. If not see > # . > > +TM_H += $(srcdir)/config/aarch64/aarch64-cores.def > +OPTIONS_H_EXTRA += $(srcdir)/config/aarch64/aarch64-cores.def > + > $(srcdir)/config/aarch64/aarch64-tune.md: $(srcdir)/config/aarch64/gentune.sh \ > $(srcdir)/config/aarch64/aarch64-cores.def > $(SHELL) $(srcdir)/config/aarch64/gentune.sh \ > --- gcc/config/arm/t-arm.jj 2013-01-11 09:03:13.000000000 +0100 > +++ gcc/config/arm/t-arm 2013-03-06 09:41:09.607528642 +0100 > @@ -18,6 +18,9 @@ > # along with GCC; see the file COPYING3. If not see > # . > > +TM_H += $(srcdir)/config/arm/arm-cores.def > +OPTIONS_H_EXTRA += $(srcdir)/config/arm/arm-cores.def > + > # All md files - except for arm.md. > # This list should be kept in alphabetical order and updated whenever an md > # file is added or removed. > > Jakub > [A