From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108449 invoked by alias); 23 Nov 2017 13:58:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 108429 invoked by uid 89); 23 Nov 2017 13:58:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=IRC, minloc2s.m4, UD:maxloc2s.m4, minloc2sm4 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-lf0-f47.google.com Received: from mail-lf0-f47.google.com (HELO mail-lf0-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 13:58:17 +0000 Received: by mail-lf0-f47.google.com with SMTP id w23so22127024lfd.11; Thu, 23 Nov 2017 05:58:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=henns/AUCWCyAtIc/hXlXgzfWx8gGv6/feYhWElF8tw=; b=oNbQiNKlexQWRiOj2n2VxfppZbZ18vY+aSwaM75NJQ+oRxtxr88Qq/nO+H/voZRgAR TvOv9JBnX6QyTHH0dOjk1H2mq9bqPgZyH0cbt3QGyut2nrigmcHQveEKOMLqGU7/6ycL orOUF6LgbNUhcjbhgTAPBQx3U1WZsW7CqL2XBHx1Xo1i8vNtfW+IqnDtu/OuaFQVr8h9 TBkRp3DWhrjiNZak7bvuzy/EWdDA7G1eMKjFEzAmYk1X9a2LHG5QItQ2tBUzAqezVHMa aAE6NEsZdhyEBg5Qqx37Jvtl6RI14dpcFIFRgscgTiLCHB3y4OqLHDS7VvM0DJiCFB3q 7zeQ== X-Gm-Message-State: AJaThX47PWpPG9t6BqHstXlfpp2ZX8TrsrCHgUn6Ihf1CaqnBMs1Y2dX GRbKfRT0O7ST1kNOsJI4j0qvZv4x7ssSyU1OdnQ= X-Google-Smtp-Source: AGs4zMb7uDF/lW1W3iI7gAJ8uLUApeJ6Amw7+4yy4UnnBpuAqHfMfxm+VxVwGw3U55Pk3lWsbdoh+TiVZog/ABYgtmo= X-Received: by 10.25.204.22 with SMTP id c22mr7148540lfg.36.1511445495428; Thu, 23 Nov 2017 05:58:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.46.88.76 with HTTP; Thu, 23 Nov 2017 05:58:14 -0800 (PST) In-Reply-To: References: <44c7b39b-d849-e31a-7175-80bf1a348908@netcologne.de> <03e85917-b506-0d8b-78b0-263c371cba6a@netcologne.de> <09d35ad1-6883-0372-7a1a-840c8c4b07f9@netcologne.de> <781c7918-5600-c488-0528-0c351ea04442@netcologne.de> From: Ramana Radhakrishnan Date: Thu, 23 Nov 2017 14:06:00 -0000 Message-ID: Subject: Re: [patch, fortran] Implement maxloc and minloc for character To: Janne Blomqvist Cc: Thomas Koenig , "fortran@gcc.gnu.org" , gcc-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg02134.txt.bz2 On Thu, Nov 23, 2017 at 1:53 PM, Janne Blomqvist wrote: > On Thu, Nov 23, 2017 at 2:56 PM, Janne Blomqvist > wrote: >> On Wed, Nov 22, 2017 at 8:10 PM, Thomas Koenig wrote: >>> Hi Janne, >>> >>>>> So, attached is a new version of the patch. No update >>>>> on the ChangeLog. OK for trunk? >>>> >>>> Yup, just really fix the copyright and string length stuff first. Thanks! >>> >>> >>> Committed as rev 255070 with the fixes. >>> >>> There are still some files which mention Fortran 95, that can be fixed >>> later. >> >> That's ok, I wasn't expecting you to fix all such occurences, just the >> new files you added. >> >> However, to continue my nitpicking (sorry!), it seems that in many >> cases compare_fcn still takes an integer length argument. Could you >> make that gfc_charlen_type as well? Or maybe size_t, since the >> argument is passed straight to memcmp{_char4} anyway? Please consider >> such a patch pre-approved. Thanks! > > To continue, the prototypes are inconsistent too, e.g. m4/minloc2s.m4: > > extern 'rtype_name` 'name`'rtype_qual`_'atype_code` ('atype` * const > restrict, int); > export_proto('name`'rtype_qual`_'atype_code`); > > 'rtype_name` > 'name`'rtype_qual`_'atype_code` ('atype` * const restrict array, > gfc_charlen_type len) > > See also lines 77/82, and in maxloc2s.m4 lines 42/46 and 144/149. > > Thanks to James and Ramana on IRC, who are working on some target > where gfc_charlen_type != int and reported build failures. I'm not sure why gfc_charlen_type != int on arm-none-eabi and aarch64-none-elf which is where both James and I saw the issue. The issue hasn't appeared on any of our cross-linux builds. regards Ramana > > -- > Janne Blomqvist