From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-377182-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 31917 invoked by alias); 9 Sep 2014 09:34:16 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 31904 invoked by uid 89); 9 Sep 2014 09:34:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-qa0-f49.google.com
Received: from mail-qa0-f49.google.com (HELO mail-qa0-f49.google.com) (209.85.216.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 09 Sep 2014 09:34:09 +0000
Received: by mail-qa0-f49.google.com with SMTP id i13so647988qae.36        for <gcc-patches@gcc.gnu.org>; Tue, 09 Sep 2014 02:34:06 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.140.107.6 with SMTP id g6mr31810099qgf.26.1410255246876; Tue, 09 Sep 2014 02:34:06 -0700 (PDT)
Received: by 10.224.74.70 with HTTP; Tue, 9 Sep 2014 02:34:06 -0700 (PDT)
Reply-To: ramrad01@arm.com
In-Reply-To: <000701cfc7e6$f2f8a260$d8e9e720$@arm.com>
References: <000701cfc7e6$f2f8a260$d8e9e720$@arm.com>
Date: Tue, 09 Sep 2014 09:34:00 -0000
Message-ID: <CAJA7tRbPgepViODZ7JzmREXRrGHV9bD8Vh1AfMKiiQBEXDc41w@mail.gmail.com>
Subject: Re: [Patch, gcc, testsuite]Disable xordi3-opt.c/iordi3-opt.c on thumb1 target
From: Ramana Radhakrishnan <ramana.gcc@googlemail.com>
To: Tony Wang <tony.wang@arm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Richard Earnshaw <Richard.Earnshaw@arm.com>, 	Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-09/txt/msg00663.txt.bz2

On Thu, Sep 4, 2014 at 3:21 AM, Tony Wang <tony.wang@arm.com> wrote:
> Hi there,
>
> This is a test case clean up patch, because orr/eor instruction for thumb1 has only two variant:
>
> ORRS <Rdn>, <Rm>
> ORR<c> <Rdn>, <Rm>
> No <shift> is available for thumb1 encoding, so test case xordi3-opt.c/iordi3-opt.c is invalid for thumb1
> target. This patch just disabled them for thumb1 target.
>
> Ok for the trunk?

Ok (assuming you've tested this on suitable multilib variants :))

Ramana

>
> gcc/gcc/testsuite/ChangeLog:
> 2014-09-04  Tony Wang  <tony.wang@arm.com>
>
>          * gcc.target/arm/xordi3-opt.c: Disable this
>          test case for thumb1 target.
>          * gcc.target/arm/iordi3-opt.c: Ditto.
>
> diff --git a/gcc/testsuite/gcc.target/arm/iordi3-opt.c b/gcc/testsuite/gcc.target/arm/iordi3-opt.c
> index b3f465b..63fbe0b 100644
> --- a/gcc/testsuite/gcc.target/arm/iordi3-opt.c
> +++ b/gcc/testsuite/gcc.target/arm/iordi3-opt.c
> @@ -1,4 +1,4 @@
> -/* { dg-do compile } */
> +/* { dg-do compile { target { arm_arm_ok || arm_thumb2_ok} } } */
>  /* { dg-options "-O1" } */
>
>  unsigned long long or64 (unsigned long long input)
> diff --git a/gcc/testsuite/gcc.target/arm/xordi3-opt.c b/gcc/testsuite/gcc.target/arm/xordi3-opt.c
> index 7e031c3..53b2bab 100644
> --- a/gcc/testsuite/gcc.target/arm/xordi3-opt.c
> +++ b/gcc/testsuite/gcc.target/arm/xordi3-opt.c
> @@ -1,4 +1,4 @@
> -/* { dg-do compile } */
> +/* { dg-do compile { target { arm_arm_ok || arm_thumb2_ok} } } */
>  /* { dg-options "-O1" } */
>
>  unsigned long long xor64 (unsigned long long input)
>
>
>